Jesse Ruderman Reporter
	Description • 17 years ago

Loading the testcase triggers:

###!!! ASSERTION: mapping request for a non-attrib enum: 'info.mEnumCount > 0 && mAttrEnum < info.mEnumCount', file /Users/jruderman/trunk/mozilla/content/svg/content/src/nsSVGEnum.cpp, line 56

Crash [@ nsSVGEnum::SetBaseValue] dereferencing 0xaaaaa222.

	Robert Longson [:longsonr] Assignee
	Comment 1 • 17 years ago

One way forward would be to give marker attribute types their own enum class either

a) derived from the ordinary enum type
b) standalone
c) an instance of some non-mapped enum type

Before embarking on this though, I really want to understand in what circumstances you should be able to use baseVal to set a value and in what circumstances it should throw 

The orientType attribute is:

readonly SVGAnimatedEnumeration orientType

and then you get

interface SVGAnimatedEnumeration { 
             attribute unsigned short baseVal;
                         // raises DOMException on setting
    readonly attribute unsigned short animVal;
  };

DOMException  	  	
NO_MODIFICATION_ALLOWED_ERR: Raised on an attempt to change the value of a readonly attribute. 

So should the example throw this error? Should all baseVal.setValue implementations just return NO_MODIFICATION_ALLOWED_ERR always except when the type is created via createSVGLength or createSVGAngle?

	Robert Longson [:longsonr] Assignee
	Comment 3 • 17 years ago

This patch sets orient to 0 if orientType.baseVal is set to ORIENT_ANGLE. I'm not sure what else I could do other than that.

	Robert Longson [:longsonr] Assignee
	Comment 4 • 17 years ago

nsSVGOrientType now initialises itself also a SetBaseValue method simplifies some calls.

	Robert Longson [:longsonr] Assignee
	Comment 5 • 17 years ago

remove aDoSetAttr from SetBaseValue since its only remaining caller passes PR_TRUE

Apologies for multiple tries and resultant bugspam.

	Robert Longson [:longsonr] Assignee
	Comment 6 • 17 years ago

Comment on attachment 295373 [details] [diff] [review]
even simpler patch

Straightforward patch that makes markers use a non-crashing version of nsSVGEnum.

	Robert Longson [:longsonr] Assignee
	Comment 7 • 17 years ago

checked in.

	Jesse Ruderman Reporter
	Comment 8 • 17 years ago

No assertions/crashes on the 1.8 branch.

	Jesse Ruderman Reporter
	Comment 9 • 17 years ago

Crashtest checked in.