Closed
Bug 410346
Opened 17 years ago
Closed 17 years ago
tagging URIs causes large increase in bookmarks observers
Categories
(Firefox :: Bookmarks & History, defect, P2)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 3 beta3
People
(Reporter: dietrich, Assigned: asaf)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
every time you tag a URI, another bookmarks observer is added.
|
Reporter | |
Comment 1•17 years ago
|
||
|
Assignee | |
Comment 2•17 years ago
|
||
And that's caused by isURITaggedInternal I guess, doesn't the observer go away when the result is GCed?
|
|
Assignee | |
Comment 3•17 years ago
|
||
er, closing containers does not remove the observer.
|
|
Assignee | |
Comment 4•17 years ago
|
||
Assignee: nobody → mano
Attachment #294973 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #294976 -
Flags: review?(dietrich)
|
|
Assignee | |
Updated•17 years ago
|
Flags: blocking-firefox3?
Priority: -- → P2
Target Milestone: --- → Firefox 3 M11
|
|
Reporter | |
Comment 5•17 years ago
|
||
Comment on attachment 294976 [details] [diff] [review]
patch
thanks, r=me.
however, this doesn't address the root cause of the reported issue, which seems to be that nsNavHistoryResult objects never get removed as bookmark observers. i'll file a follow up for that.
Attachment #294976 -
Flags: review?(dietrich) → review+
|
||
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
|
|
Assignee | |
Comment 6•17 years ago
|
||
mozilla/toolkit/components/places/src/nsTaggingService.js 1.8
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 7•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•