Several JavaScript warnings in Narcissus cause pain when run in debug builds. This eliminates them at the cost of some performance.

Comment on attachment 295011 [details] [diff] [review] patch I'm against adding runtime costs to work around strict warnings -- often there's a cheaper or compile-time way. More below, but thanks for filing this, you may have found a bug or two. > get token() { >- return this.tokens[this.tokenIndex]; >+ return this.tokenIndex < this.tokens.length ? this.tokens[this.tokenIndex] : undefined; If we get a strict warning here, we are indexing out of bounds, evaluating to undefined -- no memory safety problems of course -- but still I'd like to know the minimal testcase and debug a bit. Seems like we could initialize this.tokens to avoid the strict warning. >- } while (ss[i].label != label); >+ } while ('label' in ss[i] && ss[i].label != label); >- if (ss[i].label == label) >+ if ('label' in ss[i] && ss[i].label == label) >- while (opPrecedence[operators.top().type] > opPrecedence[tt] || >+ while (operators.top() && operators.top().type in opPrecedence && opPrecedence[operators.top().type] > opPrecedence[tt] || >- while (opPrecedence[operators.top().type] >= opPrecedence[tt]) >+ while (operators.top() && operators.top().type in opPrecedence && opPrecedence[operators.top().type] >= >- while (opPrecedence[operators.top().type] > opPrecedence[tt]) >+ while (operators.top() && operators.top().type in opPrecedence && opPrecedence[operators.top().type] > opPrecedence[tt]) >- while (opPrecedence[operators.top().type] > opPrecedence[NEW]) >+ while (operators.top() && operators.top().type in opPrecedence && opPrecedence[operators.top().type] > opPrecedence[NEW]) In all of these cases, I bet there's a prototype object (or one we could introduce) with an explicit undefined default value. /be

With the previous patch applied plus the following modification to get token return this.tokenIndex < this.tokens.length ? this.tokens[this.tokenIndex] : (print('TOKEN ERROR'),undefined); js> load('js.js') js> load('/home/bclary/tmp/google.js') TOKEN ERROR

Seems to be the first token in the script at least. s="1"; f=""; l=1; parse(s,f,l);

Closing as Narcissus isn't maintained anymore.