Marco Zehe (:MarcoZ) Reporter
	Description • 17 years ago

The list of applications that pops up if one selects "open with" "Other" in Download Managger, has no accessible names. The list items all appear empty.

STR:
1. Go to www.ohrfunk.de.
2. Select the link "Zuhören - Winamp". The link points to an .m3u file.
3. In Download Manager's first window, keep the default selected radio button "Open With", and in the combo box, select "Other..."
4. In the list of applications that pops up, the list of applications does not have accessible names. Confirmed with JAWS, AccExplorer on Windows.

Expected: The names should be accessible.

	Aaron Leventhal
	Comment 1 • 17 years ago

The app picker is here:
http://mxr.mozilla.org/seamonkey/source/toolkit/components/apppicker/content/appPicker.xul

	Aaron Leventhal
	Comment 2 • 17 years ago

Originally implemented by jmathies in bug 348808. Section 508 compliance bug.

I think other richlistitems expose a label property for each item. Marco, is that your recollection?

	Jim Mathies [:jimm] Assignee
	Comment 3 • 17 years ago

Hey Marco, can you clarify a bit what you mean by "accessible names"? Is the app picker empty, or are there entries there but something with the selection isn't working? 

	Marco Zehe (:MarcoZ) Reporter
	Comment 4 • 17 years ago

(In reply to comment #3)
> Hey Marco, can you clarify a bit what you mean by "accessible names"? Is the
> app picker empty, or are there entries there but something with the selection
> isn't working? 

For each file, there is an item created in the list. Those are xul:richlistitems. These xul:richlistitems need their label property specified, or the accessibleName for each of these will be empty. So, the screen reader sees that there are 15 items, and the selection moves correctly from item to item, but the screen reader only gets back an empty string. So in addition to setting the item's value, the label attribute must also be setup in this loop: http://mxr.mozilla.org/seamonkey/source/toolkit/components/apppicker/content/appPicker.js#115.
It should contain all info that is indicated to the user: Name of app to launch and other information that you present in each list item.

	Marco Zehe (:MarcoZ) Reporter
	Comment 5 • 17 years ago

Oops, I forgot to mention, the default implementation of the label property is here: http://mxr.mozilla.org/seamonkey/source/toolkit/content/widgets/richlistbox.xml#503

	Jim Mathies [:jimm] Assignee
	Comment 6 • 17 years ago

Hey Marco, do you know if Vista has anything built-in I can use to test something like this? If not any suggestions on how I can see this on my end?

	Marco Zehe (:MarcoZ) Reporter
	Comment 7 • 17 years ago

Jim, yes, Vista has Narrator. Go to Run..., and type Narrator. It should start speaking through your sound card. Navigate to the build you're running. If Narrator reads the items, it's most probably fixed. If you have a patch, I can do a build with it and test it myself, too. If you have questions, I'm in the QA room on the 1st floor.

	Aaron Leventhal
	Comment 8 • 17 years ago

You can also use DOM Inspector, which provides "name" under the accessible object.

	alexander :surkov (:asurkov)
	Comment 9 • 17 years ago

(In reply to comment #8)
> You can also use DOM Inspector, which provides "name" under the accessible
> object.
> 

or under accessible properties view which is a bit comfortable I guess

	Jim Mathies [:jimm] Assignee
	Comment 10 • 17 years ago

sorry it took so long..

	Marco Zehe (:MarcoZ) Reporter
	Comment 11 • 17 years ago

Comment on attachment 300758 [details] [diff] [review]
accessible patch v.1

That's working correct now! Thanks!

	Jim Mathies [:jimm] Assignee
	Comment 12 • 17 years ago

super simple patch for accessibility..

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 13 • 17 years ago

Comment on attachment 300758 [details] [diff] [review]
accessible patch v.1

a=beltzner

	Reed Loden [:reed]
	Comment 14 • 17 years ago

Checking in toolkit/components/apppicker/content/appPicker.js;
/cvsroot/mozilla/toolkit/components/apppicker/content/appPicker.js,v  <--  appPicker.js
new revision: 1.2; previous revision: 1.1
done

	Marco Zehe (:MarcoZ) Reporter
	Comment 15 • 17 years ago

Verified using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3