Closed
Bug 411449
Opened 17 years ago
Closed 17 years ago
a typo in `config/version_win.pl' (`$override_company' instead of `$override_copyright')
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: JITR, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060404 SeaMonkey/1.0.1
Build Identifier: trunk
In `config/version_win.pl', we incorrectly assign `$override_company' to `$copyright'. Instead, `$override_copyright' should be assigned to `$copyright'.
Reproducible: Always
Steps to Reproduce:
1. Open the properties dialog (using a context menu in Windows Explorer typically) for the application executable (e. g. `thunderbird.exe').
2. In the property dialog, select the `Version' tab.
3. Check the value shown next to `Copyright:'.
4. Repeat for any other binary with version info.
5. Compare the `Copyright:' strings.
Actual Results:
The values are different between the application executable and the other binaries. For the executable, the string is the same as for `Company' in the `Other version information' frame below.
Expected Results:
The `Copyright:' strings in the executable should most probably match those in other binaries.
The assignment in the Perl script also seems erroneous given the actual variable names.
Reporter | ||
Comment 1•17 years ago
|
||
Attachment #296091 -
Flags: review?(benjamin)
Reporter | ||
Comment 2•17 years ago
|
||
To slightly correct myself: I incorrectly stated that the `Copyright:' strings in the executable should match those in other binaries. Actually, this will depend on a particular setting in `module.ver'. (For Thunderbird, they will only be similar in the sense both will refer to the MPL/GPL/LGPL license trio.)
Comment 3•17 years ago
|
||
I'd like to hold off on this a bit... I'm revamping that script entirely for bug 386740
Updated•17 years ago
|
Attachment #296091 -
Flags: review?(benjamin)
Reporter | ||
Comment 4•17 years ago
|
||
OK.(In reply to comment #3)
> I'd like to hold off on this a bit... I'm revamping that script entirely for
> bug 386740
OK. :-)
Comment 5•17 years ago
|
||
I fixed this in bug 386740. Thanks for the report.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•