Closed
Bug 411494
Opened 17 years ago
Closed 17 years ago
Use PNGs as Linux window icons for SeaMonkey
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(2 files)
|
(deleted),
application/x-zip
|
neil
:
review+
|
Details |
|
(deleted),
patch
|
ajschult784
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
When bug 410215 lands, we'll be able to use PNGs instead of XPMs for Linux window icons, and we should move to those.
This probably means that we also should bring back having 16px and 32px versions, possibly even 48px versions of those (like we had before bug 321927), given that the new mechanism supports GTK dynamically using the right ones in different cases.
|
Assignee | |
Comment 1•17 years ago
|
||
Here's a zip of the new png icons to use for SeaMonkey. Those should land in mozilla/suite/branding/icons/gtk/ and all .xpm files there should get removed.
Attachment #296550 -
Flags: review?(neil)
|
|
Assignee | |
Comment 2•17 years ago
|
||
This patch has the Makefile and installer/packaging changes needed for using those PNGs. We now ship three sizes, as that's what GTK recommends in http://library.gnome.org/devel/gtk/2.8/GtkWindow.html#gtk-window-set-icon-list
Attachment #296552 -
Flags: superreview?(neil)
Attachment #296552 -
Flags: review?(neil)
|
||
Updated•17 years ago
|
Attachment #296550 -
Flags: review?(neil) → review+
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 296552 [details] [diff] [review]
Makefile and Installer changes for using PNGs
I'm not sure I can usefully review this, not having a Linux build ;-)
Attachment #296552 -
Flags: superreview?(neil) → superreview+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #296552 -
Flags: review?(neil) → review?(ajschult)
|
||
Updated•17 years ago
|
Attachment #296552 -
Flags: review?(ajschult) → review+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Thanks, checked in!
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•