Closed
Bug 412180
Opened 17 years ago
Closed 10 years ago
.toolbarbutton-text shouldn't get margin from formatting.css
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1001871
People
(Reporter: stefanh, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
.toolbarbutton-text has "margin: 0px;" in toolbarbutton.css. This causes a lot of work-arounds in other, more app- and component-specific, files ("display: none" etc). This also causes bug 381915.
What we really should have in toolbarbutton.css is "margin: 0 !important;".
|
Reporter | |
Comment 1•17 years ago
|
||
I haven't tested this enough and it only covers toolkit/themes and browser/themes yet, so it's really a WIP version. The idea is to not change anything in the ui. Well, that's not entirely true because I changed the look of text-only mode to the better imo, but apart from that everything should look the same.
|
|
Reporter | |
Comment 2•17 years ago
|
||
Comment on attachment 296834 [details] [diff] [review]
WIP
(exclude help.css changes)
|
||
Updated•17 years ago
|
Flags: blocking1.9?
|
||
Updated•17 years ago
|
Flags: wanted1.9+
Flags: blocking1.9?
Flags: blocking1.9-
|
|
Reporter | |
Updated•13 years ago
|
Assignee: stefanh → nobody
Component: XUL Widgets → Themes
QA Contact: xul.widgets → themes
|
|
Reporter | |
Comment 3•10 years ago
|
||
This was actually fixed by Dao in bug 1001871.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•