Closed Bug 412322 Opened 17 years ago Closed 13 years ago

Better GTK look for search engine button

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: micmon, Unassigned)

Details

Attachments

(3 files)

Attached image Mockup (deleted) —
[Follow-up to Bug 405210] It would be nice if the search engine button had a similar appearance as the new URL bar drop button. For bonus points, make it possible to draw the button with a custom window background color (overriding the theme color) when a search engine can be added. The button look would also make it more obvious that this part of the widget is pressable, perhaps we can even drop the arrow?
Most likely a CSS issue, not a GTK issue.
Component: Widget: Gtk → OS Integration
Product: Core → Firefox
QA Contact: gtk → os.integration
I don't think everything is in place (code wise) to do this... or is it?
Summary: Better GTK look for seach engine button → Better GTK look for search engine button
Probably not doable without widget work.
Component: OS Integration → Widget: Gtk
Product: Firefox → Core
QA Contact: os.integration → gtk
Attached image search-button-with-plus (deleted) —
I want to suggest to use "list-add" icon on the right end of search-bar, like the feed icon in the address-bar.
Attached image GTKify Manage Search Engine List (deleted) —
And adding up/down and remove icons to Manage Search Engine List buttons would complete it, and make it look really native in GNOME.
It would be relatively simple to hijack the comboboxentry drawing code to make the theme draw an attached button (just set the direction to opposite of the real one to get a button attaching to the left of the entry, and turn off the arrow drawing); it could even look great in themes like thinice who draw a button not attached, but just touching. The problem is that it's still a hack (would it look good in Crux ?), and moreover the urlbar larry button would then look out of place, and I don't know a way to make gtk draw an entry with two buttons attached: more hacks would be lurking there. It seems very fragile, and I don't think we should accept such things this late in the game; which is unfortunate because it really looks great. On the contrary, the Gtkification of the dialog seems perfectly doable and acceptable.
Depends on: 482229
We completely removed the button look (bug 415958), I don't think we want to restore it.
Status: NEW → RESOLVED
Closed: 13 years ago
No longer depends on: 482229
Resolution: --- → WONTFIX
(In reply to Dão Gottwald [:dao] from comment #7) > We completely removed the button look (bug 415958), I don't think we want to > restore it. agreed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: