Hi, I have an extension whose main window is chrome://myext/content/myext.xul I used to open it with thunderbird -chrome chrome://myext/content/myext.xul but now, it does not work anymore: I get "ReferenceError: resolveURIInternal is not defined" on the console, and thunderbird does not launch. Actually, components/nsMailDefaultHandler.js calls resolveURIInternal, but that function is defined nowhere in the file: http://mxr.mozilla.org/mozilla/source/mail/components/nsMailDefaultHandler.js#232 It seems this bug was introduced by fix for bug #395942. If I define resolveURIInternal (by copying it from http://mxr.mozilla.org/mozilla/source/browser/components/nsBrowserContentHandler.js#83), -chrome works fine again.

I don't known if it needs to be fixed on 1.8 branch. But in such a case, here is a patch for 1.8 branch

I'm a bit confused by this, I remember we fixed this on the 1.8 branch and the trunk a couple months ago to get bob clary's spidermonkey tools to work.

I remember bug 378942 for spider's -url param from last spring, and I see bug 322808 for -chrome, from the spring before, but CVS and I don't seem to remember any commandline changes a couple of months ago, post-QuickTime-pwns-Firefox.

(In reply to comment #3) > I'm a bit confused by this, I remember we fixed this on the 1.8 branch and the > trunk a couple months ago to get bob clary's spidermonkey tools to work. Scott, it looks like Bug 395942 added the use of the resolveURIInternal function in the same manner as Firefox and Seamonkey uses it... the only trouble is nsMailDefaultHandler.js doesn't have resolveURIInternal function!

Comment on attachment 297156 [details] [diff] [review] fixes bug on trunk ah I see. Thanks Rob & Phil and of course arno for making the patch!

mail/components/nsMailDefaultHandler.js 1.11

Comment on attachment 297156 [details] [diff] [review] fixes bug on trunk you could get rid of the braces here: + if (!(uri instanceof nsIFileURL)) { + return uri; + } and you could get rid of the local var urifixup and turn this into a single line, if you wanted... in any case, sr=bienvenu, thx for the patch

Oups, I did not notice patch had already been commited :( Superreview was therefore not necessary. Sorry for extra work.

Comment on attachment 297162 [details] [diff] [review] fixes bug on 1.8 branch Just in case there are any releases planned, this is important for companies who use Mozilla products as the base for additional addons but are stuck with certain branches...

Comment on attachment 297162 [details] [diff] [review] fixes bug on 1.8 branch Approved for 1.8.1.22, a=dveditz for release-drivers

Comment on attachment 297162 [details] [diff] [review] fixes bug on 1.8 branch Landed on MOZILLA_1_8_BRANCH.

Arno, can you check this with the latest 1.8 nightly (ftp://ftp.mozilla.org/pub/thunderbird/nightly/latest-mozilla1.8/)? I don't have your extension so I want to be sure it works now.

yes, it still works with 31/05/2009 nigthly

Thanks, Arno. Marking this as verify for 1.8.1.22.