When you add the Accept Languages in Preference dialog and changed the order of the languages, the order is persist even thought you hit cancel button. Steps of reproduce 1. Open the Preference dialog by selecting menu View|Preferences... 2. Click on Navigator ->Languages 3. Click on Add.. button to display "Add Languages" dialog 4. Select several languages, For example, select Albanian [sq], Bulganian [bq], and Catalan [ca], then click "OK" Now the order of Accept Language is English [en] Albanian [sq] Bulganian [bq] Catalan [ca] 5. Select English [en] and use the down allow button to move one. Now the order of Accept Language is Albanian [sq] English [en] Bulganian [bq] Catalan [ca] 6. Select Cancel button at the right bottom of the preference dialog. 7. Open the preference dialog agan The order of Accept Language is Albanian [sq] English [en] Bulganian [bq] Catalan [ca] The order of Accept Language should be back to Albanian [sq] English [en] Bulganian [bq] Catalan [ca] Tested 2000-06-01-08 Mac, Linux, and Win32 build.

over to ben, cc'ing mcafee.

Ben, this is my bad - the wsm needs to be hooked up for this pref.

reassign to ftang

low priority item. Mark it as P5 and Future. Reassign to nhotta.

Shanjian, could you take a look at this? Does this still happen?

This still happens; I'm not sure I agree with the low priority, but you know better :-)

Forgot to mention, I used Netscape 6 RTM, Windows NT US to reproduce the bug

Reassign to jbetak.

I'd suggest closing this bug. It seems that the windows state manager (wsm), which caches the user preference settings until "OK" is clicked in the preference window does not work with the list widget. This is confirmed by other preference dialogs using the list widget: Preference window->Navigator->Helper Applications Preference window->Instant Messenger->Away Alternatively, I could follow up with the UI group and file a bug requiring a change to the wsm.

reopening, marking dependency on 42893. It looks like the proposed solution in 42893 can easily accommodate this bug also.

marking 0.9.1, accepting

oops - correcting incorrect dependency

Is the patch ready? If so, please put into the status whiteboard Have you ask anyone to review. If so, please put the name (reviewer) and time (when do you ask review) here.

moving to 9.2

hrm.. I could have sworn there was a way to do this without registering an ok callback function - isn't there a way to initialize a page in the onload handler, and save is again in the unload handler?

alecf, are you referring to GetFields() or SetFields()? As far as I know, they do not provide a mechanism for that. I might be able to avoid using the call-back handler by a more artful caching of the pref value. I might trick the wsm to do it for me, but it seems kinda hacky... Are call-back handlers out of favor?

alecf: would you risk another look? I replaced the OK callback function with a slightly hacky exploit of the wsm/prefwindow caching mechanism; there is a new attribute called prefvalue on the active_languages tree. The actual widget content mapping is still done manually.

r=nhotta

quite a reasonable solution sr=alecf

adding blizzard for a=

a=blizzard on behalf of drivers for the trunk

closing after mere 369 days - thanks everyone!

note to remind self that this went into only the tip...

vrfy fixed using comm trunk bits: 2001.06.07.08 [linux and mac], 2001.06.07.09 [winnt]. how i tested this: 1. after adding languages, i clicked Cancel. reopened the prefs, and the added langs were not there --expected. 2. after adding languages, i clicked OK. reopened the prefs, and the added langs were there --expected. 3. after (2), i changed the order of the languages [moved English below Albanian], then clicked Cancel. reopened the prefs, and saw that the order of langs was unchanged --expected.