Closed Bug 412598 Opened 17 years ago Closed 17 years ago

ForecastFox extension not showing in Statusbar

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: jmjjeffery, Assigned: mrbkap)

References

Details

(Keywords: regression)

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre Firefox/3.0 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre Firefox/3.0 Starting with todays nightly build, the ForecastFox Extension has stopped displaying in the statusbar, but the slider if enabled is working, so the extension seems to be running, just not displaying. Reproducible: Always Steps to Reproduce: 1. 2. 3. These errors are in the console2: Error: '[JavaScript Error: "Components.stack.caller is null" {file: "chrome://forecastfox/content/parser/parser-service.js" line: 505}]' when calling method: [ffIParserService::getValue] = NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS Error: Components.stack.caller is null Source file: chrome://forecastfox/content/parser/parser-service.js Line: 505 Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre Firefox/3.0 ID:2008011604 Vista HP
Keywords: regression
Version: unspecified → Trunk
Works: 20080115_0848_firefox-3.0b3pre.en-US.win32 Broken: 20080115_1045_firefox-3.0b3pre.en-US.win32 Checkins to module PhoenixTinderbox between 2008-01-15 08:48 and 2008-01-15 10:44 : http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1200415680&maxdate=1200422699 Due to bug 352791? I'm requesting blocking, although it may turn out this is expected behaviour.
Blocks: 352791
Flags: blocking-firefox3?
Status: UNCONFIRMED → NEW
Ever confirmed: true
In reply to Comment #2: The problem exists with ForecastFox 0.9.6, using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre - Build ID: 2008011604.
Component: General → XPConnect
Flags: blocking-firefox3?
Product: Firefox → Core
QA Contact: general → xpconnect
Flags: blocking1.9?
Happens in Linux as well. OS -> All
OS: Windows Vista → All
Hardware: PC → All
The same for me... :-( Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre ID:2008011604
This also happens with ForecastFox Enhanced: I'm seeing this in the error console: Error: uncaught exception: [Exception... "'[JavaScript Error: "Components.stack.caller is null" {file: "chrome://forecastfox/content/parser/parser-service.js" line: 505}]' when calling method: [ffIParserService::getValue]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "<unknown>" data: yes] Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011703 Minefield/3.0b3pre ID:2008011703
mrbkap, you able to dig into this? /be
Flags: blocking1.9? → blocking1.9+
Attached patch Possible fix (deleted) — Splinter Review
This fixes this bug but I no longer have any way of testing bug 352791. Could somebody check to make sure this doesn't regress that bug? The problem is that we're now using the wrong context to execute component code on, leading it to not find a JS stack when it expects one. The patch avoids this by only using the context associated with the wrapper if there is no currently-running code to get in the way.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #297671 - Flags: superreview?(jst)
Attachment #297671 - Flags: review?(jst)
Attachment #297671 - Flags: review?(bent.mozilla)
Blocks: 412729
Blocks: 413200
Blocks: 413093
This patch also seems to fix bug 413093 and bug 413200.
Attachment #297671 - Flags: superreview?(jst)
Attachment #297671 - Flags: superreview+
Attachment #297671 - Flags: review?(jst)
Attachment #297671 - Flags: review+
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; compatible; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012116 Minefield/3.0b3pre ID:2008012116 Confirmed fixed.
No longer blocks: 413093
Status: RESOLVED → VERIFIED
So, where do we get the fix from?
> So, where do we get the fix from? The same place you got the version with the bug from, presumably: <http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/>
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: