(not currently active) Ted Mielczarek Assignee
	Description • 17 years ago

We're going to kick ourselves if we don't get this into Firefox 3.  When we eventually end of life the 1.9 branch, we should have a way for the crash reports server to tell the client to stop sending reports.  I don't know if we need to do this on a per-Build ID basis, or if just per-branch is enough, but either should be possible.  The client already gets a list of key=value parameters from the server, so we'll just make it look for a new one and save that value out, and then it can know whether to submit a report or not.  We could do this easily without changing the crashreporter GUI, or we could just disable everything in the UI except quit/restart, and have the status text say that no report will be submitted.

	(not currently active) Ted Mielczarek Assignee
	Comment 1 • 17 years ago

Filed bug 412790 for the server side, that's not as critical, as long as we test the client functionality and verify that it works.

	timeless
	Comment 2 • 17 years ago

I'd argue that it should have a way to point the user to a URL with migration information.

	(not currently active) Ted Mielczarek Assignee
	Comment 3 • 17 years ago

We already have the update service and whatnot.  That's overcomplicated.

	Benjamin Smedberg
	Comment 4 • 17 years ago

Ted, what's the use-case here: "this build is old and we don't care about reports from it any more"? or "our server is overloaded, please throttle"?

	(not currently active) Ted Mielczarek Assignee
	Comment 5 • 17 years ago

"This build is old".  I don't see any point in trying to throttle clients, our collector never gets overloaded really.  We could just drop the reports after collecting them, but that's sort of mean to users, since it would look like we were processing it, but we weren't.  Being able to stop clients in unsupported releases from submitting reports would help keep load on the processor down.

	(not currently active) Ted Mielczarek Assignee
	Comment 6 • 17 years ago

Needs a string added, but that would conflict with my other patches, so I didn't do that quite yet.  This isn't great, it will be better once I fix bug 411438, since you'll still get a restart button on the error dialog then.  Suggestions wanted for the error text, obviously "Your build is too old" is not quite user friendly.

	(not currently active) Ted Mielczarek Assignee
	Comment 7 • 17 years ago

Oh, it also needs to delete the dump file before quitting.

	(not currently active) Ted Mielczarek Assignee
	Comment 8 • 17 years ago

Deletes dump, still needs string.

	(not currently active) Ted Mielczarek Assignee
	Comment 9 • 17 years ago

Just the string, want to get this in for the string freeze.  Comments on the text welcome, but get them in quick.  ;-)

	(not currently active) Ted Mielczarek Assignee
	Comment 10 • 17 years ago

Comment on attachment 298379 [details] [diff] [review]
string [checked in]

Looking to land this string prior to string freeze so I can get the code in for b3.

	Reed Loden [:reed]
	Comment 11 • 17 years ago

Comment on attachment 298379 [details] [diff] [review]
string [checked in]

>+ErrorEndOfLife=The version of %s you are using is no longer supported.  Crash reports are no longer being accepted for this version.  Please consider upgrading to a supported version.

Can the extra spaces be dropped, please?

	(not currently active) Ted Mielczarek Assignee
	Comment 12 • 17 years ago

Comment on attachment 298379 [details] [diff] [review]
string [checked in]

Checked in, with one space after each period.  When did I get so old that things I learned in high school are no longer correct?  :-(

	(not currently active) Ted Mielczarek Assignee
	Comment 13 • 17 years ago

This implements the functionality.  The server can send "StopSendingReportsFor=VERSION" in the POST response, and the client will store a file in the Crash Reports directory named "EndOfLifeVERSION".  If the client sees that file when it is called to submit a report for that version, it will display the error screen with the above string instead.

	(not currently active) Ted Mielczarek Assignee
	Comment 14 • 17 years ago

Checked in.

	AndrewM
	Comment 15 • 17 years ago

(In reply to comment #12)
> (From update of attachment 298379 [details] [diff] [review])
> Checked in, with one space after each period.  When did I get so old that
> things I learned in high school are no longer correct?  :-(

According to Wikipedia, it's a complicated situation, but in America it changed sometime in the mid-90's: http://en.wikipedia.org/wiki/French_spacing

	Tony Chung [:tchung]
	Comment 16 • 17 years ago

hi ted, how can we test this?  is there a testcase you can provide?

	(not currently active) Ted Mielczarek Assignee
	Comment 17 • 17 years ago

Tony: you can set the environment variable MOZ_CRASHREPORTER_URL=http://mavra.perilith.com/~luser/testsubmit.pl , that's a test CGI I have that will tell your client to stop sending reports for its current version.  If you set that env var, then crash once and submit the report, then crash again, the crash reporter should give you the end of life message.  Note that submitting your report to that CGI won't actually get it processed.  Once you're done testing that, you can go to your Crash Reports directory and remove the EndOfLifeVERSION file to reset it.  (EndOfLife3.0b3 assuming that's what you're testing.)