Closed
Bug 412867
Opened 17 years ago
Closed 17 years ago
nsSimpleStreamListener needs to autoclose mSink IFF !mObserver
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
INVALID
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
Biesinger
:
review+
beltzner
:
approval1.9b3-
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
while reviewing possible approaches for transferring data from a Channel to an OutputStream, biesi suggested nsSimpleStreamListener. Unfortunately, it's simply buggy in the simple case, because there's no way for anyone to know that it's done.
Attachment #297651 -
Flags: review?(cbiesinger)
|
||
Updated•17 years ago
|
Attachment #297651 -
Flags: review?(cbiesinger) → review+
Attachment #297651 -
Flags: approval1.9?
|
||
Comment 1•17 years ago
|
||
Comment on attachment 297651 [details] [diff] [review]
close only if !mObserver
a1.9+=damons
Attachment #297651 -
Flags: approval1.9? → approval1.9+
Attachment #297651 -
Flags: approval1.9b3?
|
||
Updated•17 years ago
|
Attachment #297651 -
Flags: approval1.9b3? → approval1.9b3-
Comment on attachment 297651 [details] [diff] [review]
close only if !mObserver
mozilla/netwerk/base/src/nsSimpleStreamListener.cpp 1.10
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
ok, it turns out that one can try to know that a stream has received all the data it wants by being in control of the input and relying on everything being sync from the input.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•