Closed
Bug 413806
Opened 17 years ago
Closed 17 years ago
Land Windows icons for Beta 3
Categories
(Firefox :: Shell Integration, enhancement, P1)
Tracking
()
VERIFIED
FIXED
Firefox 3 beta3
People
(Reporter: faaborg, Assigned: faaborg)
References
Details
Attachments
(5 files, 5 obsolete files)
(deleted),
application/zip
|
Details | |
(deleted),
application/zip
|
Details | |
(deleted),
application/zip
|
Details | |
(deleted),
application/zip
|
Details | |
(deleted),
image/png
|
mtschrep
:
approval1.9b3+
mtschrep
:
approval1.9+
|
Details |
This is a tracking bug for landing the milestone 2 Windows icons for Beta 3. I'll be attaching the new icons to this bug and hopefully someone can start checking them in.
naming conventions:
name.png -> intended for XP, however these icons will initially also show up on Vista until winstripe is updated
name_aero.png -> the file that Vista should be using
Details of runtime chrome overrides to enable using different icons on Vista can be found in bug 397073
Changes involving toolbar.png are being covered in bug 411725
Flags: blocking-firefox3?
Assignee | ||
Comment 1•17 years ago
|
||
Preferences window icons for XP Luna
Assignee | ||
Comment 2•17 years ago
|
||
Let's try this again, was in the wrong folder. Preferences window icons for XP Luna.
Attachment #298897 -
Attachment is obsolete: true
Assignee | ||
Comment 3•17 years ago
|
||
Preferences window icons for Vista Aero
Assignee | ||
Comment 4•17 years ago
|
||
There is currently some discussion going on about how we want to package up the different sets for XP and Vista, so I'll attach the rest of the icons tomorrow. In the meantime feel free to check in Options.png
Comment 5•17 years ago
|
||
Comment on attachment 298898 [details]
Options.png
There's something wrong with the privacy icons, they're overlapping.
Assignee | ||
Comment 6•17 years ago
|
||
Fixed a small problem with the preferences icons for XP, thanks for catching that Dao.
Attachment #298898 -
Attachment is obsolete: true
Comment 7•17 years ago
|
||
Minimal feedback: Even knowing that Firefox 2.0's privacy icon was supposed to be a DnD sign, it took me several attempts to realize that the new icon is supposed to be a DnD sign as well. My first impression was that the icon looked like a rectangular card with a yellow helmet on. What about de-emphasizing the golden background and putting a red "do not enter" symbol on the the sign to make things clearer?
Assignee | ||
Comment 8•17 years ago
|
||
Check these four files into toolkit/themes/winstripe/global/icons/
Assignee | ||
Comment 9•17 years ago
|
||
This is all of the new windows icons that we currently have from the Iconfactory.
Attachment #298899 -
Attachment is obsolete: true
Attachment #299077 -
Attachment is obsolete: true
Attachment #299703 -
Attachment is obsolete: true
Comment 10•17 years ago
|
||
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-aero.png,v
done
Checking in browser/themes/winstripe/browser/Toolbar-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-aero.png,v <-- Toolbar-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/Toolbar.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar.png,v <-- Toolbar.png
new revision: 1.7; previous revision: 1.6
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/identity-aero.png,v
done
Checking in browser/themes/winstripe/browser/identity-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/identity-aero.png,v <-- identity-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/identity.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/identity.png,v <-- identity.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/pageStarred-aero.png,v
done
Checking in browser/themes/winstripe/browser/places/pageStarred-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/pageStarred-aero.png,v <-- pageStarred-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/places/pageStarred.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/pageStarred.png,v <-- pageStarred.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/starPage-aero.png,v
done
Checking in browser/themes/winstripe/browser/places/starPage-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/starPage-aero.png,v <-- starPage-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/places/starPage.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/starPage.png,v <-- starPage.png
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/tag-aero.png,v
done
Checking in browser/themes/winstripe/browser/places/tag-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/tag-aero.png,v <-- tag-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/places/tag.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/tag.png,v <-- tag.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/Options-aero.png,v
done
Checking in browser/themes/winstripe/browser/preferences/Options-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/Options-aero.png,v <-- Options-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/preferences/Options.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/Options.png,v <-- Options.png
new revision: 1.8; previous revision: 1.7
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/alwaysAsk-aero.png,v
done
Checking in browser/themes/winstripe/browser/preferences/alwaysAsk-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/alwaysAsk-aero.png,v <-- alwaysAsk-aero.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/alwaysAsk.png,v
done
Checking in browser/themes/winstripe/browser/preferences/alwaysAsk.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/alwaysAsk.png,v <-- alwaysAsk.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/plugin-aero.png,v
done
Checking in browser/themes/winstripe/browser/preferences/plugin-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/plugin-aero.png,v <-- plugin-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/plugin.png,v <-- plugin.png
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/find-aero.png,v
done
Checking in toolkit/themes/winstripe/global/icons/find-aero.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/icons/find-aero.png,v <-- find-aero.png
initial revision: 1.1
done
Checking in toolkit/themes/winstripe/global/icons/find.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/icons/find.png,v <-- find.png
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/wrap-aero.png,v
done
Checking in toolkit/themes/winstripe/global/icons/wrap-aero.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/icons/wrap-aero.png,v <-- wrap-aero.png
initial revision: 1.1
done
Checking in toolkit/themes/winstripe/global/icons/wrap.png;
/cvsroot/mozilla/toolkit/themes/winstripe/global/icons/wrap.png,v <-- wrap.png
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloadIcon-aero.png,v
done
Checking in toolkit/themes/winstripe/mozapps/downloads/downloadIcon-aero.png;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloadIcon-aero.png,v <-- downloadIcon-aero.png
initial revision: 1.1
done
Checking in toolkit/themes/winstripe/mozapps/downloads/downloadIcon.png;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloadIcon.png,v <-- downloadIcon.png
new revision: 1.4; previous revision: 1.3
done
Assignee: nobody → faaborg
Target Milestone: --- → Firefox 3 M11
Comment 11•17 years ago
|
||
There appear to be no 'small icons' in the landing. Using 'customize' and unchecking 'use small icons' I see the new icons, but no keyhole icon appears.
I had to open and close the cusstomize pallet, then the keyhole appeared.
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008012803 Minefield/3.0b3pre Firefox/3.0 ID:2008012803
Comment 12•17 years ago
|
||
It also appears that the drop-arrow for the Keyhole Icon is up about a pixel
too high.
http://img183.imageshack.us/img183/4475/keyholeog0.jpg
Vista HP w/ Aero enabled.
Comment 13•17 years ago
|
||
Sorry for the bug-spam - seems the Icon is OK in a new profile.
Assignee | ||
Comment 14•17 years ago
|
||
Here are the new tab browser icons, they are drop in image replacements so you can land them at your convenience.
Updated•17 years ago
|
Keywords: checkin-needed
Comment 15•17 years ago
|
||
(In reply to comment #2)
> Created an attachment (id=298898) -- Options.png
Further impressions: The Preferences icons look quite colorless on WinXP (white is much more dominant than on Firefox 2's) which makes the lock stand out when it probably shouldn't. OTOH the lock is the only icon with a different perspective which makes it stand out even more. IMO the Linux icons are quite better in both respects.
Comment 16•17 years ago
|
||
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tabDragIndicator-aero.png,v
done
Checking in browser/themes/winstripe/browser/tabbrowser/tabDragIndicator-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tabDragIndicator-aero.png,v <-- tabDragIndicator-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/tabbrowser/tabDragIndicator.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tabDragIndicator.png,v <-- tabDragIndicator.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-end-aero.png,v
done
Checking in browser/themes/winstripe/browser/tabbrowser/tab-arrow-end-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-end-aero.png,v <-- tab-arrow-end-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/tabbrowser/tab-arrow-end.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-end.png,v <-- tab-arrow-end.png
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-start-aero.png,v
done
Checking in browser/themes/winstripe/browser/tabbrowser/tab-arrow-start-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-start-aero.png,v <-- tab-arrow-start-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/tabbrowser/tab-arrow-start.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-start.png,v <-- tab-arrow-start.png
new revision: 1.3; previous revision: 1.2
done
Status: NEW → ASSIGNED
Updated•17 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 17•17 years ago
|
||
For winstripe/browser/, image drop ins so feel free to land at your convenience.
Assignee | ||
Comment 18•17 years ago
|
||
Place these four files in winstripe/browser/feeds/ Feel free to land at your convenience.
Updated•17 years ago
|
Keywords: checkin-needed
Comment 19•17 years ago
|
||
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/page-livemarks-aero.png,v
done
Checking in browser/themes/winstripe/browser/page-livemarks-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/page-livemarks-aero.png,v <-- page-livemarks-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/page-livemarks.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/page-livemarks.png,v <-- page-livemarks.png
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/audioFeedIcon-aero.png,v
done
Checking in browser/themes/winstripe/browser/feeds/audioFeedIcon-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/audioFeedIcon-aero.png,v <-- audioFeedIcon-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/feeds/audioFeedIcon.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/audioFeedIcon.png,v <-- audioFeedIcon.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/audioFeedIcon16-aero.png,v
done
Checking in browser/themes/winstripe/browser/feeds/audioFeedIcon16-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/audioFeedIcon16-aero.png,v <-- audioFeedIcon16-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/feeds/audioFeedIcon16.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/audioFeedIcon16.png,v <-- audioFeedIcon16.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/feedIcon-aero.png,v
done
Checking in browser/themes/winstripe/browser/feeds/feedIcon-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/feedIcon-aero.png,v <-- feedIcon-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/feeds/feedIcon.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/feedIcon.png,v <-- feedIcon.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/feedIcon16-aero.png,v
done
Checking in browser/themes/winstripe/browser/feeds/feedIcon16-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/feedIcon16-aero.png,v <-- feedIcon16-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/feeds/feedIcon16.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/feedIcon16.png,v <-- feedIcon16.png
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/videoFeedIcon-aero.png,v
done
Checking in browser/themes/winstripe/browser/feeds/videoFeedIcon-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/videoFeedIcon-aero.png,v <-- videoFeedIcon-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/feeds/videoFeedIcon.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/videoFeedIcon.png,v <-- videoFeedIcon.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/videoFeedIcon16-aero.png,v
done
Checking in browser/themes/winstripe/browser/feeds/videoFeedIcon16-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/videoFeedIcon16-aero.png,v <-- videoFeedIcon16-aero.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/feeds/videoFeedIcon16.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/feeds/videoFeedIcon16.png,v <-- videoFeedIcon16.png
new revision: 1.2; previous revision: 1.1
done
Updated•17 years ago
|
Keywords: checkin-needed
Comment 20•17 years ago
|
||
Is this fixed? If so, can we resolve it?
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 21•17 years ago
|
||
I guess Vista is not Windows ? There have been no Vista icons added as yet that I've seen.
Also, no small icons have landed - so I question how this can be resolved - fixed.
Assignee | ||
Comment 22•17 years ago
|
||
I just rescaled the current new home icon we have so that we can try out the new look when we move the home icon to the bookmarks toolbar.
Assignee | ||
Comment 23•17 years ago
|
||
Reopening so that Reed can land Toolbar-small.png with the new home icon.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 24•17 years ago
|
||
a=beltzner on landing Toolbar-small.png w/new home icon, but this won't block b3.
Flags: blocking-firefox3? → blocking-firefox3+
Keywords: checkin-needed
Priority: -- → P1
Target Milestone: Firefox 3 beta3 → Firefox 3 beta4
Updated•17 years ago
|
Attachment #300557 -
Flags: approval1.9b3?
Assignee | ||
Comment 25•17 years ago
|
||
>I guess Vista is not Windows ? There have been no Vista icons added as yet
>that I've seen.
They are all in, for instance: http://mxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/Toolbar-aero.png
We need to start using chrome overrides to use these files in the theme, but that's a separate issue.
Updated•17 years ago
|
Attachment #300557 -
Flags: approval1.9b3?
Attachment #300557 -
Flags: approval1.9b3+
Attachment #300557 -
Flags: approval1.9+
Comment 26•17 years ago
|
||
Checking in browser/themes/winstripe/browser/Toolbar-small.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small.png,v <-- Toolbar-small.png
new revision: 1.7; previous revision: 1.6
done
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Firefox 3 beta4 → Firefox 3 beta3
Comment 27•17 years ago
|
||
(In reply to comment #26)
> Checking in browser/themes/winstripe/browser/Toolbar-small.png;
> /cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small.png,v <--
> Toolbar-small.png
> new revision: 1.7; previous revision: 1.6
> done
>
change is "Home" icon only ?
how about others ?
Comment 28•17 years ago
|
||
the others won't be updated for Beta 3
Comment 29•17 years ago
|
||
Don't know if you guys realize this but in the customize toolbar menu if you drag those back and forward buttons into it, it shows the old style icon.
Comment 30•17 years ago
|
||
As you can see there http://img523.imageshack.us/img523/2751/bugah0.png
new icons on toolbar are vertical-unaligned and border is incomplete
Assignee | ||
Comment 31•17 years ago
|
||
Mrtb: this bug was just about checking in the images, you should head over to bug 411725 for alignment issues.
Images are in; verified fixed using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008020504 Minefield/3.0b4pre
and
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008020504 Minefield/3.0b4pre
See comment 25 for Vista-specific issues; Alex, what's the bug # that covers that?
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 33•17 years ago
|
||
Note that using the aero style icons on vista is now being covered in bug 416531.
You need to log in
before you can comment on or make changes to this bug.
Description
•