Closed
Bug 413963
Opened 17 years ago
Closed 17 years ago
Password manager has unsafe dependency on browser
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Gavin
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
Even Bugzilla thinks that the password, or should I call it login, manager is a browser component, although in CVS it lives in toolkit and there is work to get Thunderbird and SeaMonkey working with it. Unfortunately it makes assumptions about its consumers. These assumptions should be moved to notification.xml where anyone can use them.
Updated•17 years ago
|
Flags: blocking-firefox3?
Assignee | ||
Comment 1•17 years ago
|
||
If you tweak a SeaMonkey tree to build login manager then this works as expected.
Comment 2•17 years ago
|
||
Comment on attachment 299157 [details] [diff] [review]
Possible patch
This looks mostly fine, but the currentNotification handling in removeTransientNotifications needs to be fixed as discussed on IRC.
Attachment #299157 -
Flags: review?(gavin.sharp) → review-
Assignee | ||
Comment 3•17 years ago
|
||
This just removes the aImmediate parameter.
Attachment #299157 -
Attachment is obsolete: true
Attachment #299402 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 4•17 years ago
|
||
The idea of this patch is that you can remove all the notifications immediately but only if they are all transient. Otherwise they slide out.
Attachment #299413 -
Flags: review?(gavin.sharp)
Comment 5•17 years ago
|
||
Comment on attachment 299402 [details] [diff] [review]
Lazy patch
I think I prefer this one, we can support an "immediate" parameter if the need arises at some point in the future.
Attachment #299402 -
Flags: review?(gavin.sharp) → review+
Updated•17 years ago
|
Attachment #299413 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 6•17 years ago
|
||
Comment on attachment 299402 [details] [diff] [review]
Lazy patch
API cleanup.
Attachment #299402 -
Flags: approval1.9?
Comment 7•17 years ago
|
||
Comment on attachment 299402 [details] [diff] [review]
Lazy patch
a1.9+=damons
Attachment #299402 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 8•17 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Attachment #299413 -
Attachment is obsolete: true
Updated•17 years ago
|
Target Milestone: --- → Firefox 3 beta3
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•