No need to spend cycles on something we won't use. See bug 414229 comment 4 for more details.

Build finished and too many results hit the max and stop as expected.

Actually.. just to be safe, check >= instead of ==.

Comment on attachment 299616 [details] [diff] [review] v1.1 r=sspitzer, thanks edward. please let dietrich know about this change as well.

we should spin off another bug, about this: 80 // This is the maximum results we'll return for a "typed" search 81 // This happens in response to clicking the down arrow next to the URL. 82 // XXX todo, check if doing rich autocomplete, and if so, limit to the max results? 83 #define AUTOCOMPLETE_MAX_PER_TYPED 100 that should not longer be #define, but we should use mAutoCompleteMaxResults now in nsNavHistory::AutoCompleteTypedSearch() we can limit our results to the pref (25), because that's the max we'll show anyways.

again, I'm ignoring non-rich results. keep in mind that the drop down is in the url bar, and not the other two places (open location dialog and home page pref.)

Comment on attachment 299616 [details] [diff] [review] v1.1 a=beltzner

Checking in toolkit/components/places/src/nsNavHistory.cpp; /cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v <-- nsNavHistory.cpp new revision: 1.232; previous revision: 1.231 done Checking in toolkit/components/places/src/nsNavHistory.h; /cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.h,v <-- nsNavHistory.h new revision: 1.124; previous revision: 1.123 done Checking in toolkit/components/places/src/nsNavHistoryAutoComplete.cpp; /cvsroot/mozilla/toolkit/components/places/src/nsNavHistoryAutoComplete.cpp,v <-- nsNavHistoryAutoComplete.cpp new revision: 1.34; previous revision: 1.33 done

My bad. yank/paste = evil!

Comment on attachment 300172 [details] [diff] [review] followup v1 Would be useful to get feedback on good values.. if people can set the prefs.

Comment on attachment 300172 [details] [diff] [review] followup v1 a=beltzner for 1.9 and beta 3

Checking in toolkit/components/places/src/nsNavHistory.cpp; /cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v <-- nsNavHistory.cpp new revision: 1.238; previous revision: 1.237 done