Closed
Bug 414321
Opened 17 years ago
Closed 15 years ago
"ASSERTION: Someone didn't override Reflow or ComputeAutoSize"
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: jruderman, Unassigned)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review-
bzbarsky
:
superreview-
|
Details | Diff | Splinter Review |
layout/generic/crashtests/307979-1.html triggers:
###!!! ASSERTION: Someone didn't override Reflow or ComputeAutoSize: 'Not Reached', file /Users/jruderman/trunk/mozilla/layout/generic/nsLeafFrame.cpp, line 131
This assertion was changed recently, in bug 412679, so I'm guessing this is a regression from that bug.
Flags: in-testsuite+
|
||
Comment 1•17 years ago
|
||
nsHTMLFramesetBlankFrame overrides Reflow() but not ComputeAutoSize():
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/generic/nsFrameSetFrame.cpp&root=/cvsroot&mark=1835,1842#1842
OS: Mac OS X → All
Hardware: PC → All
|
|
||
Comment 2•17 years ago
|
||
Attachment #299814 -
Flags: superreview?(bzbarsky)
Attachment #299814 -
Flags: review?(bzbarsky)
|
||
Comment 3•17 years ago
|
||
Comment on attachment 299814 [details] [diff] [review]
Like so?
It's probably safer to just override ComputeAutoSize and call the nsFrame one directly...
Attachment #299814 -
Flags: superreview?(bzbarsky)
Attachment #299814 -
Flags: superreview-
Attachment #299814 -
Flags: review?(bzbarsky)
Attachment #299814 -
Flags: review-
|
Reporter | |
Comment 4•15 years ago
|
||
WFM locally. crashtests.list file doesn't show any asserts() annotations for this testcase, so safe to say WFM on Tinderbox as well.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•