Closed
Bug 41443
Opened 25 years ago
Closed 24 years ago
"frame info" and "page info" in the context menu needs to be implemented
Categories
(SeaMonkey :: Page Info, defect, P5)
SeaMonkey
Page Info
Tracking
(Not tracked)
VERIFIED
FIXED
Future
People
(Reporter: Marko.Macek, Assigned: mcafee)
References
Details
(Keywords: helpwanted, polish, Whiteboard: suntrak-n6)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
"frame info" needs to show page info window (where a full frame hierarchy should
be shown like in 4.x)
This is a most useful 4.x feature.
Comment 1•25 years ago
|
||
Sorry for the spam. New QA Contact for Browser General. Thanks for your help
Joseph (good luck with the new job) and welcome aboard Doron Rosenberg
QA Contact: jelwell → doronr
Comment 2•25 years ago
|
||
--> html frames
Assignee: asa → pollmann
Component: Browser-General → HTMLFrames
QA Contact: doronr → petersen
Comment 3•25 years ago
|
||
--> Context menu folks. Let me know if I can help with this. Thanks!
Assignee: pollmann → law
Comment 4•25 years ago
|
||
over to me --but if anyone wants to take it, feel free :-). also noticed that
"view page info" (for non-frame pages) is missing (w/respect to 4.x).
Comment 5•25 years ago
|
||
Putting on [NEED INFO] radar. Are "frame info" and "page info" on the exception
features list?
Whiteboard: [NEED INFO]
Not sure if these are on the exception features list, but I don't consider
access to page info or frame info from a context menu to be a beta 2 stopper.
Comment 8•25 years ago
|
||
Putting on [nsbeta2-] radar. Not critical to beta2.
Whiteboard: [NEED INFO] → [nsbeta2-]
Comment 9•25 years ago
|
||
Nav triage team: minus, polish, reassigning to Mcafee
Assignee | ||
Updated•25 years ago
|
Priority: P3 → P2
Comment 11•24 years ago
|
||
is frame info even implemented? If not, we need a new bug on that first.
Comment 12•24 years ago
|
||
cannot find an existing bug that covers Frame Info implementation --feel free to
create one if i don't get to it in the next coupla minutes (going thru my
bugmail, so it might be a bit...).
Comment 13•24 years ago
|
||
Adding sun tracking string
Whiteboard: [nsbeta2-][nsbeta3-] → [nsbeta2-][nsbeta3-] suntrak-n6
Comment 14•24 years ago
|
||
It would be smart to extend "Page Info" to contain the "framed" structure of a
page with clickable items to select a specific Frame
eg.
Frames on this Page
--------------------
Header -> /kljsdf/text.html
Footer -> /asdfss/set.php
Selected Frame: Header
-----------------------
Images in this Frame...
Forms in this Frame...
Then we would not need an additional item "Frame Info" and it would also be more
comfortable...
Comment 15•24 years ago
|
||
André, that is covered in the spec
<http://critique.net.nz/project/mozilla/general/component/info/> for bug 52730,
which is the parent bug of this one.
Comment 16•24 years ago
|
||
Netscape Nav triage team: this is a Netscape beta stopper. Assigning priority
P3.
Keywords: nsbeta1
Priority: P2 → P3
Updated•24 years ago
|
Target Milestone: --- → mozilla0.9
Comment 17•24 years ago
|
||
Futured and marked p5 to make room on McAfee's plate for 44733
Priority: P3 → P5
Target Milestone: mozilla0.9 → Future
Comment 18•24 years ago
|
||
just wondering: should this then be marked nsbeta1-...?
Whiteboard: [nsbeta2-][nsbeta3-] suntrak-n6 → suntrak-n6
Comment 19•24 years ago
|
||
Updated•24 years ago
|
Assignee | ||
Comment 20•24 years ago
|
||
Can we have viewFrameInfo also use BrowserPageInfo(), and pass
that last argument in? viewInfo would then call BrowserPageInfo(null)
or something like that.
patch looks good, tested it on linux & works, good work!
Comment 21•24 years ago
|
||
Comment 22•24 years ago
|
||
if (window.arguments && window.arguments[0]) seems kinda wonky to me. I think
arguments will always be defined on window, so checking for it before accessing
slot 0 doesn't get you anything. What you really want to be checking is to see
if the length >= 1, i.e. if (window.arguments.length && window.arguments[0])
with that, a=ben@netscape.com
Assignee | ||
Comment 23•24 years ago
|
||
fixed checked in, thanks to matthew for most of the work here.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 24•24 years ago
|
||
vrfy fixed using 2001.05.25.10 comm bits on linux, and 2001.05.24.0x comm bits
on mac and winnt.
Status: RESOLVED → VERIFIED
Comment 25•24 years ago
|
||
This fix was incorrect. Calling functions that live in browser files from a
global context menu is unacceptable.
Comment 26•23 years ago
|
||
nsContextMenu.js has other references to navigator-only files.
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/nsContextMenu.js#27
'This JavaScript "class" is used to implement the browser's content-area
context menu.
For usage, see references to this class in navigator.xul.
Currently, this code is relatively useless for any other purpose. In the
longer term, this code will be restructured to make it more reusable."'
Component: XP Apps: GUI Features → Page Info
QA Contact: sairuh → pmac
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•