Closed Bug 414567 Opened 17 years ago Closed 17 years ago

AMO Integration: Search icon should be the same as in the search bar on the navigation toolbar

Categories

(Toolkit :: Add-ons Manager, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9

People

(Reporter: u88484, Assigned: mossop)

References

Details

Attachments

(7 files)

Attached image Screenshot (deleted) —
In the new AMO Integration panel, the search icon should be the same as in the search bar on the navigation toolbar. See screenshot.
Blocks: 404024
Blocks: 414472
The icons I mentioned in comment #2 no longer exist, but we should be using the same search and cancel icons that we use throughout firefox for each platform.
Flags: blocking-firefox3?
We appear to be using a different icon from the searchbar on on OSX, but the same icon as is used in the searchbox on Vista and XP (though it doesn't quite fit well on Vista) just with a grey background. I suspect that Alex just copied the image over which is why it's there on XP and Vista.
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
-> Dave for resolution.
Assignee: nobody → dtownsend
Attached image OSX search (deleted) —
Attachment #312063 - Flags: ui-review?(madhava)
Attached image OSX cancel search (deleted) —
Attachment #312064 - Flags: ui-review?(madhava)
Attached image Windows search (deleted) —
Attachment #312087 - Flags: ui-review?(madhava)
Attached image Windows cancel search (deleted) —
Windows needed a bit of additional padding love
Attachment #312088 - Flags: ui-review?(madhava)
Attached patch patch rev 1 (deleted) — Splinter Review
Attached image new pinstripe icon file (deleted) —
Attachment #312063 - Flags: ui-review?(madhava) → ui-review+
Attachment #312064 - Flags: ui-review?(madhava) → ui-review+
Attachment #312087 - Flags: ui-review?(madhava) → ui-review+
Attachment #312088 - Flags: ui-review?(madhava) → ui-review+
Comment on attachment 312090 [details] [diff] [review] patch rev 1 These are the simple style tweaks necessary to fix up windows and OSX as the above screenshots.
Attachment #312090 - Flags: review?(robert.bugzilla)
Attachment #312090 - Flags: review?(robert.bugzilla) → review+
Checking in toolkit/themes/pinstripe/mozapps/extensions/extensions.css; /cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v <-- extensions.css new revision: 1.43; previous revision: 1.42 done Checking in toolkit/themes/pinstripe/mozapps/extensions/searchIcons.png; /cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/searchIcons.png,v <-- searchIcons.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v <-- extensions.css new revision: 1.54; previous revision: 1.53 done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
The checkin for bug 427555 reverted this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Dave, so this bug is not Windows only as the OS field says?
Relanded the icon. Checking in toolkit/themes/pinstripe/mozapps/extensions/searchIcons.png; /cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/searchIcons.png,v <-- searchIcons.png new revision: 1.4; previous revision: 1.3 done
Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Verified with: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008040604 Minefield/3.0pre ID:2008040604 Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008040907 Minefield/3.0pre Under Windows the height of the search box within the Get Addons panel is too flat when comparing it to the navigation bar search box. Is there already a bug about this issue? I cannot find one. If not, I'll file a new bug.
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: