Closed
Bug 414569
Opened 17 years ago
Closed 17 years ago
AMO Integration: Right-click on extension/theme results in an empty context menu
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9beta4
People
(Reporter: u88484, Assigned: mossop)
References
Details
Attachments
(3 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
mossop
:
ui-review+
|
Details |
(deleted),
patch
|
Gavin
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
In the new AMO Integration panel, a right-click on an extension/theme results in a small blank tooltip and no right click menu. Error console displays:
Error: menus is undefined
Source file: chrome://mozapps/content/extensions/extensions.js
Line: 1641
See screenshot.
Summary: AMO Integration: Right-click on extension/theme results in a very small tooltip → AMO Integration: Right-click on extension/theme results in a very small tooltip and no right click menu
Assignee | ||
Comment 1•17 years ago
|
||
Need to decide what we want in the context menu.
Comment 2•17 years ago
|
||
The tit^Wsummary of this bug should be changed. (The popup thingy is a menu, not a tooltip.)
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → dtownsend
Updated•17 years ago
|
Flags: blocking-firefox3?
Summary: AMO Integration: Right-click on extension/theme results in a very small tooltip and no right click menu → AMO Integration: Right-click on extension/theme results in an empty context menu
Comment 4•17 years ago
|
||
Not a blocker, at worst its a mild annoyance.
Flags: blocking-firefox3? → blocking-firefox3+
Assignee | ||
Comment 6•17 years ago
|
||
This is a proposed fix that is trivial to do and uses only existing strings.
Attachment #305502 -
Flags: ui-review?(madhava)
Comment 7•17 years ago
|
||
Dave, wouldn't be "Learn More" a better menu entry due to it connects to the link within the extension description?
Updated•17 years ago
|
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 8•17 years ago
|
||
Comment on attachment 305502 [details]
trivial fix suggestion
Over email, just change the text to Learn More.
Attachment #305502 -
Flags: ui-review?(madhava) → ui-review+
Assignee | ||
Comment 9•17 years ago
|
||
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•17 years ago
|
||
<beltzner> I'd just leave the accesskeys out at this point
This just reuses the existing commands, using the alternate Learn More text for the homepage menu to match the link.
Attachment #305602 -
Attachment is obsolete: true
Attachment #305608 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•17 years ago
|
Whiteboard: [has patch]
Updated•17 years ago
|
Attachment #305608 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #305608 -
Flags: approval1.9?
Comment 12•17 years ago
|
||
Comment on attachment 305608 [details] [diff] [review]
no really, no access keys
a=beltzner for 1.9
Attachment #305608 -
Flags: approval1.9? → approval1.9+
Updated•17 years ago
|
Keywords: checkin-needed
Comment 13•17 years ago
|
||
Checking in toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v <-- extensions.js
new revision: 1.163; previous revision: 1.162
done
Checking in toolkit/mozapps/extensions/content/extensions.xul;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.xul,v <-- extensions.xul
new revision: 1.71; previous revision: 1.70
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → Firefox 3 beta4
Comment 14•17 years ago
|
||
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre.
Status: RESOLVED → VERIFIED
Comment 15•17 years ago
|
||
Also verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre ID:2008022704
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•