Closed Bug 414595 Opened 17 years ago Closed 17 years ago

AMO Search results URL is getting over-escaped

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mossop, Assigned: oremj)

References

Details

If you perform a search in the addons manager and then click the link to show more then the resulting url is over escaped. For example a space is converted to %2520
Also, maybe somehow related, searching for "Ook?" fails in the AMO pane but works on AMO (https://addons.mozilla.org/en-US/firefox/search?q=Ook%3F&status=4).
the pane times out on "Ook" but immediately fails on "Ook?" Question marks in other search terms also make it fail immediately for some reason.
Assignee: nobody → dtownsend
(In reply to comment #1) > Also, maybe somehow related, searching for "Ook?" fails in the AMO pane but > works on AMO > (https://addons.mozilla.org/en-US/firefox/search?q=Ook%3F&status=4). This is a different issue with the AMO API, filed as bug 415269
This is actually an AMO redirect issue. The search url is coming out to f.e.: https://en-US.add-ons.mozilla.com/en-US/firefox/search?q=adblock%20plus AMO then redirects this to: https://addons.mozilla.org/en-US/firefox/search?q=adblock%2520plus
Assignee: dtownsend → nobody
Component: Extension/Theme Manager → Public Pages
Product: Firefox → addons.mozilla.org
QA Contact: extension.manager → web-ui
Version: Trunk → 3.2
Jeremy - could you take a look at the redirects set up on mozilla.com and see if they are escaping the query string?
I talked to oremj about this and disabling escaping for the redirects on locale.add-ons.mozilla.com would fix this -- of all in-product links, this EM link is the only one with anything in the query string, so unless anybody objects we should just make the config change for the main mozilla.com rewrites during an outage window and test to confirm.
(In reply to comment #9) > I talked to oremj about this and disabling escaping for the redirects on > locale.add-ons.mozilla.com would fix this -- of all in-product links, this EM > link is the only one with anything in the query string, so unless anybody > objects we should just make the config change for the main mozilla.com rewrites > during an outage window and test to confirm. Can we make this change please?
Jeremy can you remove escaping for the mozilla.com redirect?
Assignee: nobody → oremj
Target Milestone: --- → 3.2
Removed escaping from that redirect.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Looks good, thanks
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.