We were altering the modification time of the local copy to see if the file is editable. As such, our local copy was always newer than the one on landfill and so was never updated. My local copy was still pointing to 3.0.2 despite 3.0.3 is released for several weeks now. Definitely a blocker as administrators relying on this notification system would never know that a newer release exists, which can be bad if we do a security release. I just touched the file on landfill to update its modification time, and with this patch applied, my local installation was now able to detect the one on landfill as newer and finally downloaded it.

Comment on attachment 300212 [details] [diff] [review] patch, v1 Okay, looks fine to me. Although I don't think you have to restore the access time.

(In reply to comment #1) > (From update of attachment 300212 [details] [diff] [review]) > Okay, looks fine to me. Although I don't think you have to restore the access > time. Maybe, but this doesn't hurt as the test is just .... a test (and so its action on the access time should be ignored). We should relnote this as this information is important for administrators.

tip: Checking in Bugzilla/Update.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Update.pm,v <-- Update.pm new revision: 1.9; previous revision: 1.8 done 3.0.3: Checking in Bugzilla/Update.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Update.pm,v <-- Update.pm new revision: 1.5.2.4; previous revision: 1.5.2.3 done

utime($atime, $mtime, $local_file) returns false, meaning that it's unable to restore the access and modification times correctly. Reopening!

It appears that utime($atime, $mtime, $local_file) returns false, meaning that apache is unable to restore the access and modification times. Consequently, bugzilla-update.xml is never updated as it always appears newer than the copy on landfill. What this fix does is to delete the local copy before downloading the new one. This way $ua->mirror will really download the new copy.

Comment on attachment 318996 [details] [diff] [review] patch, v2 Yeah, this will put a bit more load on the server, but the file is tiny anyway and it won't be a problem. I assume that you tested this--I'm just giving r+ by inspection.

tip: Checking in Bugzilla/Update.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Update.pm,v <-- Update.pm new revision: 1.10; previous revision: 1.9 done 3.0.3: Checking in Bugzilla/Update.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Update.pm,v <-- Update.pm new revision: 1.5.2.5; previous revision: 1.5.2.4 done

Was relnoted in 3.0.4, removing relnote keyword.