See attachment for guidance. 1. the shadow for the site identity button where it meets the text field for the addressing area isn't right. It ends too abruptly (at least on the top -- see red circle) and it overlaps with the inner shadow of the text area darketing the corner there a bit too much. 2. the button's top and bottom shadow do not match the gray of the text field's top and bottom shadow. (see the blue circled area for an example.)

The bottom circled issue in the screenshot is fixed but there's still a wrong shadow in the top of the address and search fields as seen in the circled area in the screenshot

Kevin, in bug 431853 you said that it will be fixed. Is it true? I cannot really see this issue anymore.

I don't see it either.

At least it's really minor but the bottom line shows up a shadow which doesn't make sense because of the two extra pixels it's too long and end abrupt. I'll attach a screenshot. Alex, something to fix or can we live with it?

Yeah, I've been seeing this too with current nightlies, in a blank location bar.

I'm also seeing the outer glow get darker on the site button, we should try to fix that as well. Also effects search button.

I'll take this.

Markus, any ETA on a patch here?

Next Wednesday.

The CSS changes in this patch extend the urlbar / searchbar by 1px to all sides so that the focus ring is smoother. The patch also fixes bug 480903 because I'm already messing with the padding for #identity-icon-label.

top row: before patch, bottom row: after patch

Comment on attachment 365408 [details] [diff] [review] v1 > #urlbar-icons { > -moz-box-align: center; >- min-height: 26px; >+ min-height: 28px; > } Does the min-height actually achieve anything? I think you can just drop it. >--- a/browser/themes/pinstripe/browser/searchbar.css >+++ b/browser/themes/pinstripe/browser/searchbar.css > .searchbar-textbox > .autocomplete-textbox-container > .textbox-input-box { >- -moz-margin-start: 44px !important; >+ -moz-margin-start: 45px !important; > } That selector is twice in that file, please merge and nuke the !important.

(In reply to comment #14) > (From update of attachment 365408 [details] [diff] [review]) > > #urlbar-icons { > > -moz-box-align: center; > >- min-height: 26px; > >+ min-height: 28px; > > } > > Does the min-height actually achieve anything? I think you can just drop it. How on earth did you catch that? You're right, it doesn't have any effect. I dropped it. > >--- a/browser/themes/pinstripe/browser/searchbar.css > >+++ b/browser/themes/pinstripe/browser/searchbar.css > > > .searchbar-textbox > .autocomplete-textbox-container > .textbox-input-box { > >- -moz-margin-start: 44px !important; > >+ -moz-margin-start: 45px !important; > > } > > That selector is twice in that file, please merge and nuke the !important. Done.

Comment on attachment 365504 [details] [diff] [review] v2 Looks good to me, but I can't tell if it's correct in terms of OS X integration.

pushed: http://hg.mozilla.org/mozilla-central/rev/59ece877e2fd

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090310 Minefield/3.2a1pre ID:20090310030639 Markus, is the patch ready to ask for approval1.9.1?

Comment on attachment 365504 [details] [diff] [review] v2 a191=beltzner

...and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/462ef7d260e0 - oops

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090402 Shiretoko/3.5b4pre ID:20090402031241

This bug's priority relative to the set of other polish bugs is: P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day. bug was in the main window