In cases when the contents of an existing localstore.rdf file is not being used (with the exception of safe-mode) the toolbar icons/text preferences and icon size preferences need to be applied. These cases include: 1. localstore.rdf is absent. 2. localstore.rdf is being ignored because it has been determined to be corrupt. 3. The code in bug 404109 is ignoring the localstore.rdf to reset the toolbars to default so that the home button displays on the bookmarks toolbar. Not doing so results in an inconsistency between the displayed UI and what is selected in the preferences panel. This problem is exacerbated by the code for bug 404109 which is slated for inclusion in Firefox beta3. That is why i requested blocker and set target-milestone to beta3. Fell free to re-target as appropriate, I just wanted to make sure the appropriate people would be made aware of the issue before the beta3 release.

So, the easiest way to fix this would be to reset the toolbox as well, so that it falls back to the default mode and icon size. Another option is to read these attributes from the toolbox and explicitly apply them to the toolbars on startup.

Dao, it makes more sense to just reset everything at this point. Can you spin a quick fix for that?

Sure

(In reply to comment #0) > Not doing so results in an inconsistency between the displayed UI and what is > selected in the preferences panel. What are the steps to reproduce the inconsistency? I'm not sure I understand the problem here.

(In reply to comment #4) > (In reply to comment #0) > > Not doing so results in an inconsistency between the displayed UI and what is > > selected in the preferences panel. > > What are the steps to reproduce the inconsistency? I'm not sure I understand > the problem here. > Well, first I have done more testing and the only way to get the inconsistency is upgrading form a pre bug 4041o9 version to a post 404109 version the corrupt localstore and absent locastore.rdf issues really do not exist. Steps to reproduce: 1. launch Firefox beta 2 build with a fresh profile. 2. use customize toolbar to select small icons and no text. 3. Launch the 20070130 nightly using the same profile 4. Notice that large icons are displayed, yet when you go to customize toolabars, the use small icons checkbox is checked. To get back to small icons, it is necessary to toggle the checkbox setting twice.

Comment on attachment 300504 [details] [diff] [review] reset the toolbox a=beltzner for beta 3, fixes issue from toolbar changes

Checking in browser/themes/gnomestripe/browser/browser.css; /cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v <-- browser.css new revision: 1.172; previous revision: 1.171 done Checking in browser/themes/winstripe/browser/browser.css; /cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v <-- browser.css new revision: 1.163; previous revision: 1.162 done Checking in browser/base/content/browser.css; /cvsroot/mozilla/browser/base/content/browser.css,v <-- browser.css new revision: 1.56; previous revision: 1.55 done Checking in browser/base/content/browser.js; /cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js new revision: 1.956; previous revision: 1.955 done Checking in browser/base/content/browser.xul; /cvsroot/mozilla/browser/base/content/browser.xul,v <-- browser.xul new revision: 1.422; previous revision: 1.421 done Checking in browser/base/content/customizeToolbarSheet.js; /cvsroot/mozilla/browser/base/content/customizeToolbarSheet.js,v <-- customizeToolbarSheet.js new revision: 1.3; previous revision: 1.2 done