Closed
Bug 414876
Opened 17 years ago
Closed 17 years ago
[gtk] Unified back/forward drop-down button is too wide
Categories
(Firefox :: Theme, defect, P2)
Tracking
()
RESOLVED
FIXED
Firefox 3 beta3
People
(Reporter: ideal.wood2001, Assigned: ventnor.bugzilla)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
beltzner
:
approval1.9b3+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008013004 Firefox/3.0b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008013004 Firefox/3.0b3pre
The new drop-down button in the unified back/forward toolbar is wider than it apparently should be.
This is not a big issue with text below icons (when the toolbar buttons are considerably taller), but on other settings the drop-down button feels quite fat.
Reproducible: Always
Steps to Reproduce:
Just use the most recent trunk builds on Linux/GTK and compare its drop-down button to a native one (e.g., gedit's Open button)
Actual Results:
Minefield's drop-down button is a few pixels wider than GTK's.
Expected Results:
Should be as close to indistinguishable as possible.
Reporter | ||
Comment 1•17 years ago
|
||
Assignee | ||
Comment 2•17 years ago
|
||
Assignee: nobody → ventnor.bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #300407 -
Flags: review?(rflint)
Comment 3•17 years ago
|
||
Why is the !important needed?
Assignee | ||
Comment 4•17 years ago
|
||
It works without it, I suppose, I just didn't want any future changes to impact this button.
Attachment #300407 -
Attachment is obsolete: true
Attachment #300428 -
Flags: review?(rflint)
Attachment #300407 -
Flags: review?(rflint)
Updated•17 years ago
|
Component: Toolbars → Theme
Flags: blocking-firefox3?
QA Contact: toolbars → theme
Target Milestone: --- → Firefox 3 beta3
Comment 5•17 years ago
|
||
Comment on attachment 300428 [details] [diff] [review]
Patch 2
>Index: browser/themes/gnomestripe/browser/browser.css
>+#back-forward-dropmarker .toolbarbutton-menu-dropmarker {
>+ width: 12px;
>+}
Use the child selector here - this button type's anonymous content shouldn't be changing anytime soon.
Attachment #300428 -
Flags: review?(rflint) → review+
Updated•17 years ago
|
Assignee | ||
Comment 6•17 years ago
|
||
I'll try for B3 but I likely won't get it. This is just a couple of lines of CSS to make the unified dropdown button a more acceptable size on the toolbar.
Attachment #300428 -
Attachment is obsolete: true
Attachment #300489 -
Flags: approval1.9b3?
Attachment #300489 -
Flags: approval1.9?
Comment 7•17 years ago
|
||
It looks pretty ridiculous on Linux right now. I'd really hate to ship beta 3 as-is without this patch, especially when we've been touting all the new theme improvements.
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Target Milestone: Firefox 3 beta3 → Firefox 3 beta4
Comment 8•17 years ago
|
||
Comment on attachment 300489 [details] [diff] [review]
Fix nits
a=beltzner for beta 3 and 1.9
Attachment #300489 -
Flags: approval1.9b3?
Attachment #300489 -
Flags: approval1.9b3+
Attachment #300489 -
Flags: approval1.9?
Attachment #300489 -
Flags: approval1.9+
Comment 9•17 years ago
|
||
Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v <-- browser.css
new revision: 1.169; previous revision: 1.168
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 3 beta4 → Firefox 3 beta3
Reporter | ||
Comment 10•17 years ago
|
||
I don't want to sound like an annoying nitpicker, but the arrow is misaligned now. It's a bit to the right, as if it were still being aligned for the original button dimensions.
Comment 11•17 years ago
|
||
(In reply to comment #10)
> I don't want to sound like an annoying nitpicker, but the arrow is misaligned
> now. It's a bit to the right, as if it were still being aligned for the
> original button dimensions.
>
Are you sure it's only that arrow? I think it's a different issue.
Can you please compare it with the button on the right edge of the tab strip, or with the location's bar button?
Comment 12•17 years ago
|
||
(In reply to comment #11)
> Are you sure it's only that arrow? I think it's a different issue.
I agree. There's a bigger problem at work here.
Comment 13•17 years ago
|
||
Reporter | ||
Comment 14•17 years ago
|
||
(In reply to comment #11)
> Are you sure it's only that arrow? I think it's a different issue.
>
> Can you please compare it with the button on the right edge of the tab strip,
> or with the location's bar button?
From my screenshot, the button was previously properly aligned. Well, maybe it's one pixel off, I haven't checked, but certainly it's nowhere close to the new button or the List All Tabs button.
As for the List All Tabs button, isn't it also too wide? I never commented on its misalignment because I thought it was as a whole a temporary appearance.
You need to log in
before you can comment on or make changes to this bug.
Description
•