Starting last night, I've been seeing this sometimes when playing with XUL / XBL: ###!!! ASSERTION: Fault in cycle collector: script pointer traversal failed (ptr: 3d116a68) : 'Not Reached', file /Users/jruderman/trunk/mozilla/xpcom/base/nsCycleCollector.cpp, line 1009 I haven't been able to make a testcase, but I got it in a debugger and let peterv look at it, and I think he has a patch.

Jesse, could you try this? Thanks!

Seems to fix the problem :)

We need to fix this for beta 3, faults lead to large leaks because we stop collecting. I have a slightly different patch that should fix the problem too, I'm worried that some code assumes that QI'ing to nsIXPConnectWrappedJS means that the nsWrappedJS is still valid.

Jesse, it'd be great if you could try this one too. Sorry about making you test another one.

I got lots of ###!!! ASSERTION: How did we get here?: 'tmp->IsValid()', file /Users/jruderman/trunk/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp, line 82 while testing with the first patch.

I get that a lot with (just) the second patch, too.

Comment on attachment 300751 [details] [diff] [review] v3 Fixes a fault in the cycle collector, which make us leak a lot. Just removing some code that is obsolete, because we've already made the cycle collector pass in the correct pointer into this function.

Comment on attachment 300751 [details] [diff] [review] v3 a=beltzner