Marco Bonardo [:mak] Reporter
	Description • 17 years ago

this is a regression caused by Bug 412988
if you drag an item in the empty space under a tree it is inserted at the
wrong index (one place before!)

STR: 
- open in the library a bookmark folder
- take a bookmark and drag to bottom into the empty space
- the bookmark is inserted in the wrong place, should be appended at the end

this is because 412988 when draggin into the same container subract 1 to the index (but in Library that index is correct so it will point one position upper than correct one)

	Ondrej Brablc Assignee
	Comment 1 • 17 years ago

The fix in bug 412988 was not the right one, instead of fixing viewIndex when moving items, it was fixing the wrong position on insert. Proper fix has been delivered with bug 415043, that has landed recently. I have found this now by accident, because I was not able to reproduce the problem described in bug 412988 anymore (I was not able to trigger the correction code and was wondering why) but I was able to trigger the code using the STR by Marco (many thanks) in this bug.

	Marco Bonardo [:mak] Reporter
	Comment 2 • 17 years ago

thank you ondrej! i was nervous about this index problem :D

	Dietrich Ayala (:dietrich)
	Comment 3 • 17 years ago

Comment on attachment 301484 [details] [diff] [review]
Rollback the correction code introduced in bug 412988

thanks for followup Ondrej, r=me.

Drivers: backout of wallpaper patch that was fixed properly elsewhere.

	Asaf Romano (gone)
	Comment 4 • 17 years ago

mozilla/browser/components/places/content/treeView.js 1.36

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 5 • 17 years ago

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008021704 Minefield/3.0b4pre ID:2008021704

	Gervase Markham [:gerv]
	Comment 6 • 15 years ago

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv