Closed
Bug 41600
Opened 24 years ago
Closed 23 years ago
Attachment/signature file path containing Ja chars is displayed as garbage on the file dialog window
Categories
(MailNews Core :: Internationalization, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
Future
People
(Reporter: ji, Assigned: sspitzer)
References
Details
(Keywords: intl, platform-parity, Whiteboard: [nsbeta3-][rtm-]Fix in hand)
Attachments
(3 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Build: 2000060508 comm
When settting the file path for signature file, if the file path contains Ja
characters,
the file path is displayed as garbage on the file dialog window.
Steps of reproduce:
1. Create a signature file with a Japanese filename under a Japanese directory
name.
2. Launch Mail.
3. Select Edit | Mail/News Account Settings.
4. Click on Choose button to set the file path of signature file, you'll get a
file dialog window. On this file dialog widow, the directory and file name in
the filepath of the signature file is displayed garbage. But after you choose
the signature file, the filepath
is displayed alright on the account setting window.
This doesn't happen on Windows.
I mentioned that after choosing the signature file, the filepath is displayed
alright on the account setting window. But I noticed that after the setting is
saved and opened again,
the filepath is displayed as garbage as well. These two problems may be related.
Please let me know if I need to file a seperate bug for this
Comment 2•24 years ago
|
||
>But I noticed that after the setting is saved and opened again,
>the filepath is displayed as garbage as well.
Is this also Linux only?
No. It also happens on Windows. Will file a separate bug for it.
Comment 5•24 years ago
|
||
put pp
Scott please reassign to the owner of this.
Assignee: nhotta → putterman
Keywords: pp
Comment 8•24 years ago
|
||
mass moving to M18 and adding nsbeta3 keyword
Keywords: nsbeta3
Target Milestone: M17 → M18
Comment 9•24 years ago
|
||
A duplicate of 41083, or the other way????
Comment 10•24 years ago
|
||
Reporter | ||
Comment 11•24 years ago
|
||
This is a linux specific bug. The Ja signature file path
is initially displayed as garbage on the file dialog window which is popped up
by clicking the Choose button on the account setting window.
This is not a dup of 41083, but 41606 is.
Comment 12•24 years ago
|
||
I have fixed the prefs issue (36965) so I can now fix this bug very easily.
Updated•24 years ago
|
Priority: P3 → P2
Comment 15•24 years ago
|
||
- per mail triage. Since "after you choose the signature file, the filepath is
displayed alright on the account setting window."
Whiteboard: [nsbeta3+] → [nsbeta3-]
Comment 17•24 years ago
|
||
Actually I have a fix in hand, and I have to fix this to fix 42102
Whiteboard: [nsbeta3-] → [nsbeta3-]Fix in hand
Keywords: rtm
Summary: Signature file path containing Ja chars is displayed as garbage on the file dialog window → Attachment/signature file path containing Ja chars is displayed as garbage on the file dialog window
Reporter | ||
Comment 18•24 years ago
|
||
The file dialogue window for attch file also has this problem.
To reproduce:
0. Have a Japanese directory name and filename somewhere in your machine.
1. Open mail compose window.
2. Click on Attach button
3. On the file dialogue window, go to the place where you have Ja directory name
and filename
On the directory/file list, the Japanese directory name and file name are
displayed alright. But once you select it, it will be displayed garbled on the
filepath.
Nominating for rtm.
Comment 19•24 years ago
|
||
marking [rtm-]
Whiteboard: [nsbeta3-]Fix in hand → [nsbeta3-][rtm-]Fix in hand
Comment 21•24 years ago
|
||
filters/search UI->gayatrib
Assignee: alecf → gayatrib
Status: ASSIGNED → NEW
Comment 23•24 years ago
|
||
Moving this bug to sspitzer.
I think we should fix this bug before the next release.
Assignee: alecf → sspitzer
Comment 24•24 years ago
|
||
Is this a dup of 60941?
Comment 25•24 years ago
|
||
No, hotta-san, this bug depends on bug 60941, but not dup bug.
Comment 26•24 years ago
|
||
This bug occurs since it uses datatype="nsIFileSpec" on am-main.xul
We should rewrite to nsILocalFile.
Comment 27•24 years ago
|
||
sorry. you ignore my comments.
Hotta-san, That's right!!
This bug should be dup of 60941
No longer depends on: 60941
Updated•24 years ago
|
Severity: normal → major
Comment 28•24 years ago
|
||
marking nsbeta1- as per I18N triage. But if we have a fix in hand already, feel
free to pursue it.
Comment 29•24 years ago
|
||
Mass change of QA contact to ji for the bugs filed by her.
QA Contact: momoi → ji
Comment 30•24 years ago
|
||
ji, could you reproduce on latest build?
Comment 31•24 years ago
|
||
Comment 32•24 years ago
|
||
hotta san, could you review?
Comment 33•24 years ago
|
||
Please also ask sspitzer for a review.
My questions,
* What is GetFilePref -> GetFileXPref for?
* In nsMsgCompose.cpp, it's converting back to nsIFileSpec. Is this because
msgCompose uses nsIFileSpec? Would it be a big change if you also need to change
msgCompose to use nsILocalFile?
* In nsMsgComposeParams.h, +#include "nsString.h", is this related to this bug?
Reporter | ||
Comment 34•24 years ago
|
||
Checked the latest linux mtrunk build (2001-01-29-08-mtrunk).
The problem originally described in the report is gone.
Comment 35•24 years ago
|
||
> * What is GetFilePref -> GetFileXPref for?
Because I want to use nsILocalFile. This problem is nsIFileSpec.
> * In nsMsgCompose.cpp, it's converting back to nsIFileSpec. Is this
> because msgCompose uses nsIFileSpec? Would it be a big change if
> you also need to change msgCompose to use nsILocalFile?
I already tried changing to all nsILocalFile. But nsIFileStreams.h and
nsIFileStream.h occured conflict... So this change is too hard since all
mailnews codes must change.
> In nsMsgComposeParams.h, +#include "nsString.h", is this related
> to this bug?
Because I changed from #include "nsFileSpec.h" to #include "nsILocalFile.h".
nsFileSpec.h include nsString.h
Comment 36•24 years ago
|
||
Xianglan, you mentioned that the original problem has gone.
Is there any remaining problem?
Reporter | ||
Comment 37•24 years ago
|
||
The system I tested with is RH6.2J and it only has EUC support.
The path containing Ja characters can be displayed correctly in the file
dialogue window. The only convern left is the shift-jis locale support in UNIX
environment, like HPUX. If it works in shift-jis locale, we can resolve this as
worksforme.
Added shanjian on the CC list.
Comment 38•24 years ago
|
||
Katakai-san has Solaris. Maybe he or Tajima-san can check this
on their Solaris under Shift_JIS locale.
Comment 39•24 years ago
|
||
Comment 40•24 years ago
|
||
Comment 41•24 years ago
|
||
Comment 42•24 years ago
|
||
I've verified Kato-san's latest patch on Solaris EUC and Shift_JIS locale.
Reporter | ||
Comment 43•23 years ago
|
||
Checked 05/17 trunk build. It's fixed even w/o Kato-san's patch.
Resolved it as fixed. Please reopen it if you see the problem in SJIS locale.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•