Closed Bug 416055 Opened 17 years ago Closed 17 years ago

Beta 3 l10n builds are missing the Application Folder icon

Categories

(Firefox :: Installer, defect, P1)

PowerPC
macOS
defect

Tracking

()

VERIFIED FIXED
Firefox 3 beta4

People

(Reporter: tchung, Assigned: reed)

References

Details

Attachments

(4 files)

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3 Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3 For the beta 3 l10n builds on mac, the installer is missing the Applications folder in the window. Repros on Mac 10.4 and Mac 10.5. ** See screenshot. note that en-US does not have this problem. Reproducible: Always Steps to Reproduce: 1. download a mac locale build from the beta 3 rc3 directory. (eg. ja-JP, de) 2. unpack the archive, and accept the EULA 3. Verify in the installer, the Mac Application folder is missing Actual Results: Missing Application folder where the installer gets dragged to. Expected Results: Application folder is there.
Attached image Missing Application folder screenshot (deleted) —
Flags: blocking-firefox3?
Priority: -- → P1
Summary: Beta 3 l10n builds are missing the APl → Beta 3 l10n builds are missing the Application Folder icon
Target Milestone: --- → Firefox 3 beta4
Version: unspecified → Trunk
Attached patch patch - v1 (deleted) — Splinter Review
Simple as this? Basically, bug 320155 added the symlink to browser/installer/Makefile.in but not to browser/locales/Makefile.in. :(
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #301813 - Flags: review?(mark)
Depends on: 320155
Comment on attachment 301813 [details] [diff] [review] patch - v1 Yeah, that's the stuff
Attachment #301813 - Flags: review?(mark) → review+
Attachment #301813 - Flags: approval1.9?
Attachment #301813 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Flags: blocking-firefox3? → blocking-firefox3+
Checking in browser/locales/Makefile.in; /cvsroot/mozilla/browser/locales/Makefile.in,v <-- Makefile.in new revision: 1.59; previous revision: 1.58 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Keywords: relnote
This doesnt look right. See screenshot for ja on latest nightly. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008021604 Minefield/3.0b4pre
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached image ja b4pre screenshot (deleted) —
What do you see on en-US nightly (for comparison)? What's the user agent on the ja nightly you're using?
Tony, the beta 3 en-US disk image doesn't have the word "Applications" on it. I don't believe there is supposed to be a label, per the mockup given in bug 320155. If you believe it should say "Applications", I think you should file a new bug for that.
Missing the label is not the bug. It's missing the background image from beta 3 is what i'm complaining about -- https://bugzilla.mozilla.org/attachment.cgi?id=299926.
The background image will only appear in branded builds. Nightlies aren't branded.
(In reply to comment #10) > The background image will only appear in branded builds. Nightlies aren't > branded. Yes, I really hope we're not saying "Firefox" on unofficial builds. If we are, that's a bug. Could somebody post a screenshot of the Mac installer on en-US for a current nightly for comparison?
en-US nightly installer screenshot
So, what's the problem? They look the same to me, except in the ja screenshot, you have the Applications icon selected so that you see the blank name for it.
This bug is fixed. Tony, the "issue" you're seeing is expected. Branding only displays on official builds. Nightlies have never had branding including background dmgs (go download a branch nightly and compare it to Firefox 2.0.0.12).
Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
alright then. will check this on beta 4 rc.
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; es-ES; rv:1.9b4) Gecko/2008030317 Firefox/3.0b4. Symlink for locales are fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: