User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12 The border colors of the the two mentioned controls differ form each other, so the look is somehow unequal. I will attach a screenshot to show the difference in fx2 versus fx3 including rgb-values. fx2: favicon container RGB: 150/150/157 urlbar RGB: 150/150/157 fx3: favicon container RGB: 172/168/153 urlbar RGB: 127/157/185 Reproducible: Always Steps to Reproduce: 1.have a look at the location bar. 2. 3. style it a uniform way

Could you please update to the latest nightly/beta3 candidate and test again? By your screenshot, it looks like you used beta 2 (since the separator is shown, which changed a long time ago). There has been a lot of changes recently to the location bar and endcaps so it might be correct now.

(In reply to comment #3) I've updated the screenshot, but the color difference is still present. You can also see the difference between the search-engine-icon-container and the searchbar.

Confirming that this is still happening with: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008030806 Minefield/3.0b5pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008030806 Minefield/3.0b5pre

Lawrence, please set version to Trunk.

See attachment 308182 [details] and attachment 308310 [details] for comparison.

We need to fix this as part of the site-identity button styling changes. I think the easiest thing to do is carry the grey/brown colour used for the edge of the button around the entire field.

(In reply to comment #9) > We need to fix this as part of the site-identity button styling changes. I > think the easiest thing to do is carry the grey/brown colour used for the edge > of the button around the entire field. > That will result in a _even more_ non-native field. Just revert the left border and that's it.

(In reply to comment #10) > (In reply to comment #9) > > We need to fix this as part of the site-identity button styling changes. I > > think the easiest thing to do is carry the grey/brown colour used for the edge > > of the button around the entire field. > > > > That will result in a _even more_ non-native field. I don't like that either. It was a step forward that we're using the native appearance, e.g. a blue border on Luna, inset style on Vista etc. > Just revert the left border and that's it. What do you mean by revert?

(In reply to comment #11) > What do you mean by revert? Sorry, I meant: go back to Firefox 1.5 location bar, which had a _native_ location bar that looked awesome: http://mozillalinks.org/wp/wp-content/uploads/firefox_classic.png http://photos1.blogger.com/photoInclude/blogger/5187/388/1600/winstripe.png

Sorry for the spam, but please tell that the old location bar doesn't feel more native than the current one...

We have a nuanced position when it comes to nativeness, curving the left side of the location bar to mirror the keyhole obviously isn't native, but it part of our overall strategy of balancing nativeness with the creation of a recognizable appearance.

We could remove the background in the normal case, which would make the overall appearance lighter and fit semantically (no identity information supplied). For verified domain / identity, we'd use blue / green. I think this makes it less visible that the border colors aren't the same.

(In reply to comment #14) > We have a nuanced position when it comes to nativeness, curving the left side > of the location bar to mirror the keyhole obviously isn't native, but it part > of our overall strategy of balancing nativeness with the creation of a > recognizable appearance. > You guys need to stop the "creation of a recognizable appearance" when it is nothing but buggy, like in this case. The damn thing doesn't provide any new use, for Christ's sake; just a bug! If you can't correct your new stuff, just use /old/ stuff. Working around for new stuff just because of identity is just silly.

(In reply to comment #15) > Created an attachment (id=310962) [details] > compromise? > > We could remove the background in the normal case, which would make the overall > appearance lighter and fit semantically (no identity information supplied). For > verified domain / identity, we'd use blue / green. I think this makes it less > visible that the border colors aren't the same. Dao, I appreciate your attempt to find a compromise design. An essential feature of the site button though, is that unlike the padlock, it is always there as a visual element, that you can always interact with it to obtain information. Obviously, your design change wouldn't prevent it from being a click target, but it would look identical to the FF2, non-interactive version, and hence be substantially less discoverable, in my view. Alex has said in bug 417844 that he has incoming graphics that will replace the current button styling for different levels of SSL. What is the likelihood that this will also resolve the border issue described here?

(In reply to comment #17) > Dao, I appreciate your attempt to find a compromise design. An essential > feature of the site button though, is that unlike the padlock, it is always > there as a visual element, that you can always interact with it to obtain > information. Obviously, your design change wouldn't prevent it from being a > click target, but it would look identical to the FF2, non-interactive version, > and hence be substantially less discoverable, in my view. I understand this approach, but frankly I think it failed when me made it depend on the favicon. And since it doesn't look like there will be a label for verified domains, it becomes really easy to miss the difference. A background for the default case would make the interactivity more discoverable, but I question whether that's a big deal; users aren't going to click it all the time just in case. At this point, "no information--no funky background" seems to make more sense to me. > Alex has said in bug 417844 that he has incoming graphics that will replace the > current button styling for different levels of SSL. What is the likelihood > that this will also resolve the border issue described here? Unlikely, because the border isn't part of the graphics.

>Unlikely, because the border isn't part of the graphics. What if we used the graphics for the entire button, instead of only the background.

(In reply to comment #19) > What if we used the graphics for the entire button, instead of only the > background. Doesn't really solve the problem, it rather makes it worse. You can't use the native textbox border color in the graphics.

as suggested by beltzner

Checking in browser/themes/winstripe/browser/browser.css; /cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v <-- browser.css new revision: 1.192; previous revision: 1.191 done Checking in browser/themes/winstripe/browser/searchbar.css; /cvsroot/mozilla/browser/themes/winstripe/browser/searchbar.css,v <-- searchbar.css new revision: 1.25; previous revision: 1.24 done