Closed
Bug 417125
Opened 17 years ago
Closed 16 years ago
PRBool misuse bugs in typeaheadfind
Categories
(SeaMonkey :: Find In Page, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
not sure how to go about these. Seems that another way to "fix" these is to eithe rremove the error checking or convert them to asserts.
|
||
Updated•16 years ago
|
Product: Core → SeaMonkey
|
Assignee | |
Updated•16 years ago
|
Attachment #302946 -
Flags: superreview?(roc)
Attachment #302946 -
Flags: review?(roc)
I'd convert them to asserts. This is private API, no-one should be calling it with null params here.
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #302946 -
Attachment is obsolete: true
Attachment #339275 -
Flags: superreview?(roc)
Attachment #339275 -
Flags: review?(roc)
Attachment #302946 -
Flags: superreview?(roc)
Attachment #302946 -
Flags: review?(roc)
Attachment #339275 -
Flags: superreview?(roc)
Attachment #339275 -
Flags: superreview+
Attachment #339275 -
Flags: review?(roc)
Attachment #339275 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
pushed c30d3bdb2bd5
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Assignee: nobody → tglek
You need to log in
before you can comment on or make changes to this bug.
Description
•