Elmar Ludwig Reporter
	Description • 17 years ago

from bug 401322 comment #108:
> We haven't shipped with fullZoom yet, so I guess this won't affect
> compatibility too much, but users that have set their zoom prefs to "5"
> will be broken here. I don't see any other in-tree apps that use 5 by
> default, but some may expose it in their pref UI (suite/common/pref/pref-
> mousewheel.xul does, it seems). Need to make sure that the relevant app
> owners are CCed, or that bugs are filed.

The patch in bug 401322 is going to remove the separate mouse wheel action for MOUSE_SCROLL_FULLZOOM again and makes it so that MOUSE_SCROLL_ZOOM - formerly known as MOUSE_SCROLL_TEXTSIZE - does either full zoom or text zoom depending on the setting of the pref "browser.zoom.full". Since SeaMonkey has UI for this mouse action (bug 394522), the mouse wheel preferences pane needs to be updated for this change as well.

A little bit of background information:

When the UI for page zoom in Firefox landed (bug 389628), a new mouse wheel action for full page zoom was introduced in bug 401214, MOUSE_SCROLL_FULLZOOM. Because the UI for text zoom was completely removed from Firefox, there has been an effort in bug 401322 to allow users the choice of text zoom or full zoom (using the same UI that was proposed for SeaMonkey in bug 405133). During the discussion in that bug it turned out that having two different zoom events was not such a good idea, and so MOUSE_SCROLL_FULLZOOM is going away again. Instead, MOUSE_SCROLL_ZOOM (formerly called MOUSE_SCROLL_TEXTSIZE) will obey the pref "browser.zoom.full" introduced in bug 405133 for SeaMonkey. This preference is now used by Firefox as well for the same purpose.

	neil@parkwaycc.co.uk Assignee
	Comment 1 • 17 years ago

It's not quite the previous version, of course... this is still a toolkit prefwindow, and I removed the text size label rather than the zoom label.

	neil@parkwaycc.co.uk Assignee
	Comment 2 • 17 years ago

Fix checked in.