User-Agent: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9b3) Gecko/2008020513 Firefox/3.0b3 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9b3) Gecko/2008020513 Firefox/3.0b3 bookmark folder icon in bookmarks toolbar use two icons: stock folder and dropdown arrow I'm using Firefox 3.0 beta with Gnome integration and the Tango theme, and I just switched to Beta 3. Now the many bookmark folders I have in my toolbar use, what, 20% more space with this drop down icon. Space in this toolbar is very expensive. Before the change, I could keep 2 or 3 more bookmarks visible on the screen. Now, on the next bookmark I add, the toolbar is full. I read bug #404825 and from what I understood, you should drop the folder icon, it will save more space. Reproducible: Always Steps to Reproduce: 1. using Firefox 3 under Gnome 2. adding bookmarks folders to the bookmarks toolbar 3. counting how many bookmarks fit on the screen with and without the folder icon. Actual Results: Less space for these shortcuts I use everyday. Expected Results: I would like to store more bookmarks on the same line. This is vanilla Firefox downloaded from mozilla.org, I'm not using any Debian package.

I agree, in Firefox for Linux the new down arrow is really space wasting! You should focus more on saving space in this toolbar by keeping the icon at minimum width and removing that unnecessary arrow. Thanks

I completely agree. Most of my bookmark folder names have only one letter or character to optimally use the precious space. Adding the down arrow wastes a lot! Now that we are at it: it would be nice to be able to hide to folder icon as well! A setting in about:config would do for me.

is this still valid for current version or nigtly build?

i see this on Ubuntu, i can't tell why Linux is acting differently from other OSes. Alex, any idea? is this something we could polish for 3.1?

This feels like a dupe, although I'm not entirely sure. I'm in favor of removing the drop down arrows, not just because it takes up a lot of space, but also because the images being uplifted from the OS theme tend to often appear overly large, as if they were designed for a very different context. But while I'm in favor of removing them, I'm cc'ing some people who worked on the tango theme so they have a chance to provide counter points for keeping the drop down arrows.

Today I found a very clean work-around. Just create a file with the following name in your profile directory. chrome/userChrome.css chrome here is a directory; if it does not exist create it as well. Put the following CSS rules in it. The first line removes the drop-down arrow; the second line hides the icons. .bookmark-item[container] > .toolbarbutton-menu-dropmarker { display: none !important; } .bookmark-item > .toolbarbutton-icon { display: none; }

Right, but the more critical decision is what users are given by default (since only a tiny of fraction of people go to that level of customization).

Alex, the css already contained a display: none, so it's quite clear that original plans were to remove that dropmarker, as in other platforms, but that rule does not apply correctly. Linux theme is forcing a moz-appearance, so overriding it should be the correct rule, and wfm on Ubuntu 8.10.

Comment on attachment 356707 [details] [diff] [review] patch > .bookmark-item > .toolbarbutton-menu-dropmarker { >- display: none; >+ -moz-appearance: none !important; > } Looks like you want to remove the following rule: > /* Dropmarker for folder bookmarks */ > .bookmark-item[container] > .toolbarbutton-menu-dropmarker { > display: -moz-box !important; > }

Just to sum up the previous discussion about this: - FF2 had "folder icon + label" - we (GTK/Tango) didn't like this and requested "label + droparrow" instead - IIRC we had this for a while, then someone requested to re-add the folder icons IMHO folder "folder icon + label" is still the worst choice because this way a bookmark folder looks exactly like a bookmark.

(In reply to comment #11) > IMHO folder "folder icon + label" is still the worst choice because this way a > bookmark folder looks exactly like a bookmark. and it is like that in all OSes, so you're saying this is globally bad, or is a specific Linux issue/requirement? Apart the fact the icon shows already it is a folder rather than a livemark container rather than a query...

Argh, lately i must be blind, sorry. Notice we won't push this patch unless a decision is taken from UX team, due to comment 11.

I think there was an effort to do exactly this during the FF3 cycle but it was backed out due to too many complaints about not being able to quickly distinguish folders from simple bookmarks.

(In reply to comment #14) > I think there was an effort to do exactly this during the FF3 cycle but it was > backed out due to too many complaints about not being able to quickly > distinguish folders from simple bookmarks. The removal of the icon was backed out in bug 413294.

and some discussion is in bug 404825

looking at gnome higs http://library.gnome.org/devel/hig-book/stable/toolbars-labels-tooltips.html.en and considering the bookmarks toolbar a toolbar with label on the right, the correct behaviour seems to be the current one, with both icon and dropdown arrow. So this would become a wontfix.

Hi, I've reported this bug. I don't understand how people can't distinguish folders from bookmarks because: 1. You have created them yourself, so you know what they do. 2. Having a simple bookmark with the Tango folder icon would require to bookmark a website using this icon as a favicon. You have added this bookmark on your own will, so you can't really be fooled. I agree with bug 404825, I want to keep the folder icon, I'm in favour of hiding the dropdown arrow. It's nice people point out the Gnome HIG because I have actually configured my Gnome toolbars to display with labels on the right of the icon. It doesn't mind because toolbars are generally limited in space to fit on smaller screens. On the opposite the Firefox bookmarks toolbar is expansible. I would understand the rejection of my request because of UI team's or Gnome's guidelines. Now that I have seen how to customize it using CSS, I could finely tune my toolbar to meet my needs. Some "compact" option in the preferences or "about:config" would be better. Think of Gnome applications that follow the system-wide or user-wide settings by default but can override them. Thanks to all of you who have gave time to this issue.

>Just to sum up the previous discussion about this: > >- FF2 had "folder icon + label" >- we (GTK/Tango) didn't like this and requested "label + droparrow" instead >- IIRC we had this for a while, then someone requested to re-add the folder >icons > >IMHO folder "folder icon + label" is still the worst choice because this way a >bookmark folder looks exactly like a bookmark. I agree with the GTK/Tango team that label + drop down is the best way to go. I propose we wontfix this bug, and then do two follow up bugs: -remove the folder icons -try to make the drop down arrow smaller (possibly needing to provide our own graphic if we can't scale the OS provided image well)

(In reply to comment #19) > propose we wontfix this bug, and then do two follow up bugs: > -remove the folder icons hum, what's the purpose of this if it was already tried and user complained (so it was backed out) + gnome higs show an icon for toolbars?

>-remove the folder icons reopened bug 404825 >-try to make the drop down arrow smaller (possibly needing to provide our own >graphic if we can't scale the OS provided image well) filed new bug 473454

>hum, what's the purpose of this if it was already tried and user complained (so >it was backed out) + gnome higs show an icon for toolbars? Overall goal is to make the interface appear cleaner. In terms of users complaining, I think we need to take that into the context of people's reluctance for change, and that people are more motivated to provide negative feedback than positive feedback. In terms of the gnome HIG, it doesn't really talk about a secondary smaller toolbar like the one we are providing. We could also consider trying to convince the writers of the gnome HIG to adapt their document so that other applications follow similar guidelines to create a crisper and more streamlined UI. If we can't make an application on Linux that looks as good as an app on OS X, I think it might be worthwhile to question the rules being imposed on Linux. And not just to improve our Firefox theme there, but also the visual design of future Linux applications. This is an advantage that we don't have on Windows.

I'm glad this bug is being discussed so actively these days. I can only provide you with one more user feedback: the actual FF 3.0 linux interface is really annoying as far as it concerns with the toolbar folders. Firefox has been my only choice under both windows and linux since the beginning always with the default theme, but when I've last seen my theme upgraded I felt the urge to change it in less than 24 hours of usage. I'm currently using Phoenity Modern and feel the styling much more compact and agreeable. Of course it is not integrated with GNOME desktop, however its solution of "folder_icon+name" is far better than the default one for who has several bookmarks and folders in the toolbar. I can't see any urgent reason to customize my folders' icons, but indeed I do to save space on my laptop screen. Unfortunately most GNOME developers seem to own large screens, for I can complain of several others cases of wasted space in this desktop environment I use on a daily basis. At least providing a simple way to toggle the behavior of the default theme (eg. through a "preferences" button in the theme addon list) would be highly welcomed. Thanks.

Comment on attachment 356715 [details] [diff] [review] patch Details in comments #19 to #22

resolving wontfix for the above reasons exposed by Alex.

Hi, this is the bug reporter again. Could someone just post the canonical CSS rule or configuration change I need to apply on my profile to remove either the folder icon or the dropdown icon? Is it close tot comment #10 or #13? Thanks in advance.