Comment on attachment 311363 [details] [diff] [review] Patch for 3.0.4 Release notes - v2 Couple of minor points I noticed when looking through it: >+<ul> >+ <li>Bugzilla::Update never updated bugzilla-update.xml if the file already >+ exists locally, thus Bugzilla administrators were never noticed about new >+ releases. noticed -> notified >+ <li>A new CSS was added to gather all site customizations and ease the maintenance >+ of a customized Bugzilla installation. >+ (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=251740">[% terms.Bug %] 251740</a>)</li> A new CSS *file*

Comment on attachment 311363 [details] [diff] [review] Patch for 3.0.4 Release notes - v2 >Index: template/en/default/pages/release-notes.html.tmpl >+ <li>Bugzilla::Update never updated bugzilla-update.xml if the file already >+ exists locally, thus Bugzilla administrators were never noticed about new >+ releases. s/noticed/notified/ as Colin said. >+ <li>There were unnecessary line breaks and excessive indentation in email >+ subject lines. >+ (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=374424">[% terms.Bug %] 374424</a>)</li> This is the wrong bug number. It's bug 411544. >+ <li>'Test' in mail_delivery_method didn't generate a valid mbox file preventing >+ using it for QA tests. Not sure this one is important enough to be listed here. >+ <li>A new CSS was added to gather all site customizations and ease the maintenance >+ of a customized Bugzilla installation. Also not sure this one should be listed here. Also, it's a new CSS *hook*. Should be listed: - Many bug fixes about email_in.pl (92274, 377025, 412943, 413672). - You could previously clear the resolution of resolved bugs, without reopening them (424380). - You could close a bug as VERIFIED and CLOSED with no resolution (418863). - merge_users.pl now correctly rederives group memberships based on regexps when merging two user accounts (422111). - checksetup.pl now correctly upgrades installations containing tables using Latin1 encoding, UTF-8 or a mix of both (374951). - Comments written in CJK languages are now correctly displayed (388723). - On Windows, temporary files created when uploading attachments are now correctly deleted when the upload is complete (414002). - Many improvements in the documentation. >+ For details, see the >+ <a href="http://www.bugzilla.org/security/3.0.4/">Security Advisory</a></p> The URL is wrong. Should be 3.0.3/ instead of 3.0.4/.

> s/noticed/notified/ as Colin said. fixed > This is the wrong bug number. It's bug 411544 fixed > Not sure this one is important enough to be listed here. It has the relnote keyword for trunk. I let it for now. > Also not sure this one should be listed here. Also, it's a new CSS *hook*. It has the relnote keyword for trunk. I added 'hook' and let it for now > Should be listed: > ... Added > The URL is wrong. Should be 3.0.3/ instead of 3.0.4/. fixed

Comment on attachment 311831 [details] [diff] [review] Patch for 3.0.4 Release notes - v3 >+ <li>There were many bug fixes about email_in.pl. >+ (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=92274">[% terms.Bug %] 92274</a>), >+ (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=377025">[% terms.Bug %] 377025</a>), >+ (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=412943">[% terms.Bug %] 412943</a>), >+ (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=413672">[% terms.Bug %] 413672</a>) Please remove parens between each bug number. Only keep the very first one and very last one. Also, there is a missing </li> at the end. r=LpSolit with this comment addressed. Please upload a new patch and carry forward my r+.

Fixed. forwarding r+

Fixing security advisory directory

Comment on attachment 317347 [details] [diff] [review] Patch for 3.0.3 Release notes - v5 > à partir d'une version précédente</a>. Si vous effectuez une mise à jour à partir d'une version antérieure > à la version 2.22, assurez-vous de lire toutes les > <a href="#v30_previous">notes de versions précédentes</a> entre votre version Please attach the *english* release notes. :)

Sorry for the previous mess..

Okay, here's the relnotes with some updates.

Comment on attachment 319308 [details] [diff] [review] v6 Maybe mentioning that process_bug.cgi is more robust when resolving/reopening bugs would make sense, but maybe is that not visible enough as you have to hack the URL in a non-obvious way. Anyway, r=LpSolit

tip: Checking in template/en/default/pages/release-notes.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/release-notes.html.tmpl,v <-- release-notes.html.tmpl new revision: 1.16; previous revision: 1.15 3.0 branch: Checking in template/en/default/pages/release-notes.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/release-notes.html.tmpl,v <-- release-notes.html.tmpl new revision: 1.1.2.11; previous revision: 1.1.2.10 done