Closed Bug 419076 Opened 17 years ago Closed 16 years ago

don't use the mLeftIsExact/mRightIsExact output from calculateHypotheticalBox

Categories

(Core :: Layout: Positioned, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(1 file)

I think after bug 403328 lands, the mLeftIsExact / mRightIsExact outputs from nsHTMLReflowState::CalculateHypotheticalBox will become unneeded, although we may still want to assert about them in DEBUG builds. If I'm wrong, however, I think there's a pretty major bug in the code that uses them, which is that the following change needs to be made: // Well, we don't know 'left' so we have to use 'right' and // then solve for 'left' - mComputedOffsets.right = hypotheticalBox.mRight; + mComputedOffsets.right = containingBlockWidth - hypotheticalBox.mRight; rightIsAuto = PR_FALSE; since otherwise mComputedOffsets.right is in the wrong coordinate system!
So yeah. With the landing for bug 403328, it looks like mLeftIsExact is always true when the block containing the placeholder is LTR and mRightIsExact is true when it's RTL. So we can just remove those two else clauses: they're dead code.
Attached patch remove unneeded code (deleted) — Splinter Review
Attachment #320060 - Flags: superreview?
Attachment #320060 - Flags: review?
Attachment #320060 - Flags: superreview?(bzbarsky)
Attachment #320060 - Flags: superreview?
Attachment #320060 - Flags: review?(bzbarsky)
Attachment #320060 - Flags: review?
Attachment #320060 - Flags: superreview?(bzbarsky)
Attachment #320060 - Flags: superreview+
Attachment #320060 - Flags: review?(bzbarsky)
Attachment #320060 - Flags: review+
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0
Assignee: nobody → dbaron
Target Milestone: mozilla2.0 → mozilla1.9.1
Target Milestone: mozilla1.9.1 → mozilla1.9.1a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: