OK : 20080225_1336_firefox-3.0b4pre.en-US.win32.zip NG : 20080225_1416_firefox-3.0b4pre.en-US.win32.zip bug 403263 seem to cause this.

Middle-clicking a bookmark throws: ASSERT: null node Stack Trace: 0:PU_nodeIsFolder(null) 1:BT_onClick([object MouseEvent]) 2:onclick([object MouseEvent])

Checkins to module PhoenixTinderbox between 2008-02-25 13:36 and 2008-02-25 14:15 : http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1203975360&maxdate=1203977759

Comment on attachment 305703 [details] [diff] [review] patch working correctly, code appear correct

To avoid nightlies hitting this bug on the b4-freeze-day, I'm going to land this with post facto approval / blocking status.

mozilla/browser/base/content/browser-places.js 1.96 mozilla/browser/components/places/content/bookmarksPanel.xul 1.11 mozilla/browser/components/places/content/controller.js 1.207 mozilla/browser/components/places/content/history-panel.xul 1.15 mozilla/browser/components/places/content/places.js 1.131 mozilla/browser/components/places/content/sidebarUtils.js 1.4 mozilla/browser/components/places/content/utils.js 1.104

verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre and the same nightly on Win XP

Looks like this caused bug 421210.

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv