Closed Bug 419740 Opened 16 years ago Closed 16 years ago

drag and drop in bookmarks menu closes the menu unexpectedly

Categories

(Firefox :: Bookmarks & History, defect, P2)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3 beta4

People

(Reporter: wgianopoulos, Unassigned)

References

Details

(Keywords: regression) 

Since the landing of the fix for bug 389931, it is no longer possible to reorder the items in the bookmarks menu via drag-and-drop while the menu is open.  Once you start dragging and item, the menu will spontaneously close and the item you are trying to drag will open in the content area when you release the mouse button.

I actually found and reported this issue while testing the patch for bug 389931, but had to wait till that actually landed to file a regression patch.

The patch I attached on bug 418156 fixes this issue as well.
Flags: blocking-firefox3?
WFM in Vista, str used:

 open Bookmarks menu
 move into Mozilla Firefox folder
 drag bookmarks around
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
Flags: blocking-firefox3? → blocking-firefox3-
(In reply to comment #1)
> WFM in Vista, str used:
> 
>  open Bookmarks menu
>  move into Mozilla Firefox folder
>  drag bookmarks around
> 

This does NOT WFM using this build:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022702 Minefield/3.0b4pre ID:2008022702

under WIN/XP.

This DOES work using the 2008022604 nightly as the patch for bug 389931 is NOT included in that build.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
I just tried in safe-mode and still see the issue.
still another issue with ondragexit in the handler in browser-places.js, i already saw that with previous TM patches. Surely you patch fixes it because it removes that bogus handler
Works for me with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre ID:2008022704

Marco, I don't understand your last comment. Which issue do you mean? What I can see is that dropping a link at a new position doesn't exit the d&d handler correctly. The bookmark will be placed at the new position when you move your mouse. Should this be filed as a new bug or is there already an existing one?
(In reply to comment #5)
> Works for me with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre)
> Gecko/2008022704 Minefield/3.0b4pre ID:2008022704

What operating system is this under?
It's a German version of Windows XP SP2. But that shouldn't make a difference for this particular issue. Perhaps you are also seeing my mentioned issue.
(In reply to comment #7)
> It's a German version of Windows XP SP2. But that shouldn't make a difference
> for this particular issue. Perhaps you are also seeing my mentioned issue.
> 

Yes just wondering if it were Vista as we already had a WFM comment under Vista.

Just to make sure everyone understands the issue I am complaining about, this happens in the Bookmarks Menu, not the bookmarks toolbar or the bookmarks sidebar or the (Bookmarks->show all bookmarks, places organizer Library or whatever we are calling it this week).

Steps to reproduce my issue are:

1.  In the Main menu bar (the one that says "File Edit View History Bookmarks Tools Help") left-click the word bookmarks and release the mouse button.
2.  In the dropdown menu that appears, pick a bookmark about halfway down the list and left click and hold the mouse button down on that bookmark.
3.  Slowly begin to drag the bookmark upward in the menu.

After about 1 second of dragging, the menu closes.

This is happening for me on 2 different PCs running Windows/XP SP2.  I have no issue with either of these PCs dragging and dropping within this menu if I backout the patch for bug 389931.  I have tried safe-mode, switching from Luna to Windows classic theme, reorganizing my bookmarks so that the menu does not overflow the window.  None of these seem to help.
i can reproduce on both XP and Vista with latest trunk (Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre). moving a bookmark inside the bookmarks menu. as i already said the code involved is the same as for Bug 418156.
Summary: can no longer drag and drop in bookmarks menu → drag and drop in bookmarks menu closes the menu unexpectedly
This is incredibly annoying, this really needs to block Firefox3.
Flags: blocking-firefox3- → blocking-firefox3?
I can confirm this issue per comment 8 on Vista 64, and yes it is annoying.
OS: Windows XP → All
This is not OS ALL.  This bug is Windows only.  It appears we need a generic Windows or Windows all choice for OS in Bugzilla.

In any event it is NOT an OS all bug.  The corresponding Linux only bug is bug 418156.  However the Linux issue is different in that it was not a regression from bug 389931, as it pre-existed that check-in.
OS: All → Windows XP
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre] (nightly) (W2Ksp4)

This happens when trying to move a bookmark within a folder of the Personal Toolbar too. (Not only with the window Bookmarks menu.)
This should be fixed by bug 418156.
Yes, I tried the latest hourly (20080301_0709, the first that includes the patch from Bug 418156) and did a lot of drag and drop. I couldn't find a way to reproduce this bug.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008030107 Minefield/3.0b4pre ID:2008030107
-> Fixed
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Reopening as bug 418156 was backed out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
On:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9b4pre) Gecko/2008030206 Minefield/3.0b4pre ID:2008030206 

this seems to work again for me.
this isn't fixed at all. per comments c#15/c#16/c#17 let's wait untill bug 418156 gets fixed for real.
Fixed again.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Target Milestone: --- → Firefox 3
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008030305 Minefield/3.0b4pre ID:2008030305
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Target Milestone: Firefox 3 → Firefox 3 beta4
No longer blocks: 194319
Flags: in-litmus? → in-litmus+
Aakash, did you add a new Litmus test or or why it was getting set to in-litmus+?
Hrm, that's interesting. There must have been some issue with my internet connection and bugzilla when I committed the message.

Either way, there's a test case in litmus that takes care of this bug. The link is: https://litmus.mozilla.org/show_test.cgi?id=6073 . 

Now, I'd like to talk about it as the test case is a bit too general. There's a number of bookmarks test cases that should be separated into more specific ones including the one mentioned here, but that will be for a discussion on the irc #qa channel though.
The given test is really general. It doesn't tell anything about that regression (closing the menu). We better shall create a new litmus test to cover it.
Flags: in-litmus+ → in-litmus?
After further digging, a new test case was created for regression testing. The link is: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=7457
Flags: in-litmus? → in-litmus+
That looks fine. Thanks for your patience with me.
Flags: in-litmus+ → in-litmus?
Flags: in-litmus? → in-litmus+
Test case https://litmus.mozilla.org/show_test.cgi?id=7535 was created on litmus for the 3.0 test run as well.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.