Andrés Delfino Reporter
	Description • 17 years ago

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008030610 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008030610 Minefield/3.0b5pre

The location bar uses a semi-transparent page icon for a new page, IMO, the same should be used in a new tab.

See screenshot.

Reproducible: Always

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 2 • 17 years ago

Confirmed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008041104 Minefield/3.0pre ID:2008041104

	Kai Liu
	Comment 3 • 16 years ago

Beyond consistency (I never noticed this discrepancy until now), a motivation for changing this would be that reducing the opacity for new blank tabs would have allow the user to quickly distinguish between tabs that are empty and tabs that have loaded a page that doesn't have a favicon.

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 4 • 16 years ago

Kevin, something which could be made with a next proto version on OS X?

	Kai Liu
	Comment 5 • 16 years ago

I just finished taking a quick look at how one might implement this for Windows, and it'll require mucking around in browser.js--which takes it out of the realm of just a simple theme change.

	Ed Lee :Mardak
	Comment 6 • 16 years ago

Guard against switching to the faded/less opaque version the same (but opposite) way that we check if we should use the defaultFavicon.

	Ed Lee :Mardak
	Comment 9 • 16 years ago

Well that's odd. Apparently the tab icons got changed too. :p I suppose that's an undesired sideeffect.

	Ed Lee :Mardak
	Comment 10 • 16 years ago

False alarm. :) My mouse happened to be over the tab when taking the screenshot.

(Thought it was weird that that one line could change tab opaqueness. :p)

	Alex Faaborg [:faaborg] (Firefox UX)
	Comment 11 • 16 years ago

What does v1 do exactly?  Prevent the icon from ever being faded?

	Ed Lee :Mardak
	Comment 12 • 16 years ago

For the icon in the urlbar, it won't be faded if it's showing the generic favicon.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 13 • 16 years ago

Comment on attachment 347457 [details] [diff] [review]
v1

(In reply to comment #12)
> For the icon in the urlbar, it won't be faded if it's showing the generic
> favicon.

We explicitly implemented that behavior to distinguish "loaded" vs. empty/edited location bars, and have code in browser.js to support it. If we're changing our minds about what a faded icon means we should just adjust that logic in URLBarSetURI (not have validity depend on a non-blank value). I'm not sure that's what we really want to do, though - seems like it would be better to fade out the icons of unloaded tabs per comment 3 / comment 5.

	Alex Faaborg [:faaborg] (Firefox UX)
	Comment 14 • 16 years ago

>We explicitly implemented that behavior to distinguish "loaded" vs.
>empty/edited location bars

I don't have an incredibly strong opinion on this, but in general I think the reason I don't like the faded icon is that it conveys two pieces of information:  pageness, and not loaded.  I get that this was the intention, but the disabled appearance seems a little odd right next to the location bar that has the focus (clearly not disabled).

Just showing the default favicon only coveys once piece of information "pageness," so conceptually it is slightly less to think about. Having good visibility of system status and feedback is of course important, but in this case the small amount of extra complexity of loadedness feels excessive, since it is self apparent that about:blank is not currently loading, and if it has loaded is kind of a philosophical argument :)

>seems like it would be better
>to fade out the icons of unloaded tabs per comment 3 / comment 5.

yep, if people want to keep the faded appearance we should just make it consistent.

	Alex Faaborg [:faaborg] (Firefox UX)
	Comment 15 • 16 years ago

Comment on attachment 347457 [details] [diff] [review]
v1

Re-requesting review to simplify the interface, and to avoid the appearance of a disabled state.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 16 • 16 years ago

Comment on attachment 347457 [details] [diff] [review]
v1

As I tried to explain in comment 13, this patch is wrong no matter what we choose to do. If we want the equivalent of this patch's behavior, we should change the URLBarSetURI code as I described in comment 13.

	Ed Lee :Mardak
	Comment 17 • 16 years ago

faaborg, could you summarize what the user experience should be when this bug gets fixed? For a given tab, there's up to 2 favicons shown -- in the tab and in the location bar. Right now, any unfocused tab will show a faded favicon in the tab and any focused (or hovered) tab will show an unfaded favicon in the tab.

I'm guessing this bug covers the case of a focused tab, so we'll be seeing both the location bar favicon and the current tab's favicon.

For the following situations, what should happen to the 2 favicons (url/tab)? Here's what happens now..

page has favicon: solid favicon url, solid favicon tab
page no favicon: solid default url, solid default tab
empty url (about:blank): faded default url, solid default tab
edited url: faded default url, solid default tab

	Dão Gottwald [:dao]
	Comment 18 • 16 years ago

(In reply to comment #17)
> page has favicon: solid favicon url, solid favicon tab
> page no favicon: solid default url, solid default tab
> empty url (about:blank): faded default url, solid default tab
> edited url: faded default url, solid default tab

it's "edited url: faded default url, solid favicon tab".

	Alex Faaborg [:faaborg] (Firefox UX)
	Comment 19 • 16 years ago

I suggest that in all situations where we use a default favicon we do not fade it (rationale in comment #14) although I don't have a very strong opinion.

	Ed Lee :Mardak
	Comment 20 • 16 years ago

In other words, always show a solid favicon in the location bar?

Potentially down the line if we were to show the favicon of the currently selected entry in the autocomplete, would that be solid or faded? (User typed in a word -> solid default favicon.. then the user presses down to an entry with a favicon -> show favicon of the page solid/faded?)

	Alex Faaborg [:faaborg] (Firefox UX)
	Comment 21 • 15 years ago

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.

this icon appears in the main window