Closed
Bug 42213
Opened 25 years ago
Closed 25 years ago
Mac-Security prefs not saved to disk
Categories
(Core Graveyard :: Security: UI, defect, P3)
Tracking
(Not tracked)
VERIFIED
WORKSFORME
People
(Reporter: junruh, Assigned: javi)
References
Details
(Whiteboard: [nsbeta2-]ETA???[nsbeta3+])
M16 Commercial builds - Win32 and Linux.
1.) Open PSM by clicking on the lock.
2.) Click on Applications, and deselect all four options.
3.) Close PSM and restart Netscape.
4.) Open PSM and click on Applications.
What is expected: That the prefs would be deselected.
Putting on [nsbeta2+] radar for beta2 fix.
FYI - Build 2000-06-12-01-M16/
jar crashed and had to reboot (WinNT)
leger froze the app and had to force quit (Win95)
doing these four steps to reproduce this bug.
Adding crash keyword.
Keywords: crash
Whiteboard: [nsbeta2+]
M16 has been out for a while now, these bugs target milestones need to be
updated.
Reporter | ||
Updated•25 years ago
|
Target Milestone: M16 → M17
Assignee | ||
Comment 5•25 years ago
|
||
This appears to be a bug in the prefs library which does not mark any of the
security preferences as having user values and always returns the default value
even when the user changes the value.
Who in prefs land can take a look at this to tell me how to fix this? Or fix
the prefs library to have the expected behavior.
Assignee | ||
Comment 6•25 years ago
|
||
Adding mstoltz to cc list since he knows something about security prefs.
Comment 7•25 years ago
|
||
I'm looking at it, but I can't figure out what's going wrong. I don't think the
fact that it's a security pref is the issue here, since the security check is
succeeding (as it should). After the security check, we call PREF_SetBoolPref as
always, which should set the USER_SET or whatever flag to true. cc'ing alec.
Assignee | ||
Comment 8•25 years ago
|
||
Here's another data point for alecf and mstoltz to help me out with.
When we call mPrefs->SetBoolPref() the flags do get update to include
PREF_USER_VALUE, but when we call mPrefs->GetBoolPref the next time around, the
flags have been re-set to only include 0x80
Any clues as to where the flags may be getting cleared?
Assignee | ||
Comment 9•25 years ago
|
||
Turns out that Mozilla didn't like the JavaScript that was used to save the
prefs in the security advisor. I re-wrote the bit of JS Mozilla didn't like and
now the preferences are saved to disk. You need a version of PSM build on or
after 7/18 to see this work.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•25 years ago
|
||
Reopening. Some prefs still are not saved.
1.) Open PSM, and click on Applications and Navigator.
2.) Select "Ask every time."
3.) Click on advanced and options.
4.) Deselect one or both SSL versions.
5.) Close PSM, close Netscape 6, and restart.
What happens: Open PSM and view the same prefs. They are not saved. WinNT build
71720, PSM.exe build 7/18 3:10 AM.
What happens: Those prefs are not saved.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 11•25 years ago
|
||
Fixed all other prefs except S/MIME prefs. Since Mozilla doesn't do S/MIME it
doesn't support those prefs anyway. You'll need a build from 7/19 or later of
PSM.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Comment 12•25 years ago
|
||
javi - this did at some point work. what javascript stop working? what did you
have to change?
Assignee | ||
Comment 13•25 years ago
|
||
I don't know if this ever worked. It involved re-writing some inputs that
looked like this:
<input type=... onClick="top.variableName = value;">
to
<input type=.. onClick="top.setVariableValue();">
Once the appropriate setVariableValue was defined, everything worked just fine.
Reporter | ||
Comment 14•25 years ago
|
||
Reopening. Verified on WinNT and Linux - still a problem with Mac. Removing
crash keyword.
Status: RESOLVED → REOPENED
Keywords: crash
OS: All → Mac System 9.0
Hardware: All → Macintosh
Resolution: FIXED → ---
Summary: Security prefs not saved to disk → Mac-Security prefs not saved to disk
Reporter | ||
Comment 15•25 years ago
|
||
Fixed
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 17•25 years ago
|
||
Reopening. I fixed and verified the wrong bug.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 18•25 years ago
|
||
javi, can we get and ETA on a fix please. Need fixed ASAP to make beta2.
Whiteboard: [nsbeta2+] → [nsbeta2+]ETA???
Assignee | ||
Comment 19•25 years ago
|
||
I don't have an ETA for this. Sorry to say I don't have a Mac that builds just
yet (I'm gonna start working on that.)
When I fixed this problem for the other platforms, there was a bug in JavaScript
that I had to code around in the JavaScript for the security advisor. Look at
my previous comment in this bug for how I worked around the problem. The actual
problem I believe lies in JavaScript.
Comment 20•25 years ago
|
||
I think the problem is that the MAC psm from a branch tag (SECURITY_MAC_BRANCH)
which has not been updated with your fix. The question is do we update the
branch tag or move the branch tag to the tip of PSM.
Comment 21•25 years ago
|
||
Per today's PR2 open nsbeta2+ bug triage, we are moving this bug from [nsbeta2+]
to [nsbeta2-]. Adding relnote2 keyword. junruh, please get text to verah.
Keywords: relnote2
Whiteboard: [nsbeta2+]ETA??? → [nsbeta2-]ETA???
Reporter | ||
Comment 22•25 years ago
|
||
Relnote sent to vera - "Mac-Security prefs not saved to disk" Changes to
preferences in the Mac Security Advisor are not saved to disk.
Assignee | ||
Comment 23•25 years ago
|
||
Will work on updating the Mac codebase to other platforms this week. Hopefully
the PSM_MAC_BRANCH will be updated by the end of this week.
Whiteboard: [nsbeta2-]ETA??? → [nsbeta2-]ETA???[nsbeta3+]
Reporter | ||
Comment 24•25 years ago
|
||
Worksforme now.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 26•24 years ago
|
||
Mass changing Security:Crypto to PSM
Component: Security: Crypto → Client Library
Product: Browser → PSM
Target Milestone: M18 → ---
Version: other → 2.1
Reporter | ||
Comment 27•24 years ago
|
||
Mass changing Security:Crypto to PSM
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•