Closed
Bug 422772
Opened 17 years ago
Closed 16 years ago
reduce narrow windows API calls in embedding
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: blassey, Assigned: crowderbt)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #309217 -
Flags: review?(benjamin)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 309217 [details] [diff] [review] directy from "other" patch on bug 418703 >Index: extensions/auth/nsAuthSSPI.cpp >- initFun = (PSecurityFunctionTable (*)(void)) >+ initFun = (PSecurityFunctionTableW (*)(void)) > GetProcAddress(sspi_lib, "InitSecurityInterfaceA"); Obviously incorrect!
Attachment #309217 -
Flags: review?(benjamin) → review-
|
|
||
Comment 2•16 years ago
|
||
Crowder asked on IRC why this was incorrect: it's because you're taking the address of InitSecurityInterfaceA and assigning it to a function pointer with the wide signature. You presumably mean to change it to InitSecurityInterfaceW.
|
Assignee | |
Comment 3•16 years ago
|
||
Ah, thanks! Sorry, overlooked the "A" on the end there. :)
|
|
Assignee | |
Comment 4•16 years ago
|
||
Assignee: nobody → crowder
Attachment #309217 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #334781 -
Flags: review?
|
|
Assignee | |
Updated•16 years ago
|
Attachment #334781 -
Flags: review? → review?(benjamin)
|
|
||
Comment 5•16 years ago
|
||
Comment on attachment 334781 [details] [diff] [review] v2 please reindent properly before checkin
Attachment #334781 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 6•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/73d8df3129ac
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•