Closed
Bug 422913
Opened 17 years ago
Closed 17 years ago
Ellipsis in "Report Broken Web Site…" should be localizable
Categories
(Other Applications Graveyard :: Reporter, defect)
Other Applications Graveyard
Reporter
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: masa141421356, Assigned: masa141421356)
References
()
Details
(Keywords: l12y, late-l10n)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
masa141421356
:
review+
beltzner
:
ui-review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031304 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031304 Minefield/3.0b5pre
Spun off from Bug 373623 Comment #115
Now ,ellipsis(…) in "Report Broken Web Site…" is not localizable.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #309400 -
Flags: review?(mconnor)
Assignee | ||
Updated•17 years ago
|
Version: unspecified → Trunk
Comment 2•17 years ago
|
||
Comment on attachment 309400 [details] [diff] [review]
Patch rev.1.0
r=me, but please change reporterMenu.title2 to reporterMenu2.title as some tools depend on the suffixes...
Attachment #309400 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 3•17 years ago
|
||
Changed reporterMenu.title2 to reporterMenu2.title
Attachment #309400 -
Attachment is obsolete: true
Attachment #309425 -
Flags: review?(mconnor)
Assignee | ||
Comment 4•17 years ago
|
||
Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1
Carrying over review
Attachment #309425 -
Flags: review?(mconnor)
Attachment #309425 -
Flags: review+
Attachment #309425 -
Flags: approval1.9?
Comment 5•17 years ago
|
||
Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1
a1.9=beltzner
Attachment #309425 -
Flags: approval1.9? → approval1.9+
Comment 6•17 years ago
|
||
This patch changes the string, can we land this?
Assignee: nobody → masa141421356
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•17 years ago
|
Status: NEW → ASSIGNED
Component: General → Reporter
Keywords: checkin-needed,
late-l10n
Product: Firefox → Other Applications
QA Contact: general → xul-client
Comment 7•17 years ago
|
||
Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1
Oh, no, not now. My bad. Ask for nomination again after Beta 5.
Attachment #309425 -
Flags: approval1.9+ → approval1.9-
Updated•17 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 9•17 years ago
|
||
Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1
nomination again
(After beta5)
Attachment #309425 -
Flags: approval1.9- → approval1.9?
Assignee | ||
Comment 10•17 years ago
|
||
Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1
According to Mozilla Developer News, "ui-review+" is needed to checkin this patch.
But, there is no ui of bugzilla to set "ui-review?".
How should I do ?
Comment 11•17 years ago
|
||
This isn't really a ui change, it's a localization change. You should be ok without.
Comment 12•17 years ago
|
||
Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1
a=beltzner
Attachment #309425 -
Flags: approval1.9? → approval1.9+
Updated•17 years ago
|
Attachment #309425 -
Flags: ui-review?(beltzner)
Comment 13•17 years ago
|
||
Can we land this now? Or, is ui-review needed?
Updated•17 years ago
|
Flags: blocking1.9?
Updated•17 years ago
|
Attachment #309425 -
Flags: ui-review?(beltzner) → ui-review+
Updated•17 years ago
|
Keywords: checkin-needed
Comment 14•17 years ago
|
||
checked-in, thank you.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: blocking1.9?
Keywords: checkin-needed
Resolution: --- → FIXED
Assignee | ||
Comment 15•17 years ago
|
||
This comment explains check-in of this bug.
http://groups.google.co.jp/group/mozilla.dev.l10n/browse_thread/thread/1aa5193536c20531?hl=ja#
Patch checked in patch seems to be Rev1.0 (Attachment 309400 [details] [diff]),
not Rev1.1 (Attachment 309425 [details] [diff]).
Comment 16•17 years ago
|
||
(In reply to comment #15)
> Patch checked in patch seems to be Rev1.0 (Attachment 309400 [details] [diff]),
> not Rev1.1 (Attachment 309425 [details] [diff]).
No problem.
Not Rev1.0, but Rev1.1.
See http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/extensions/reporter/locales/en-US/chrome/reporterOverlay.dtd&rev=1.5&cvsroot=/cvsroot
Assignee | ||
Comment 17•17 years ago
|
||
(In reply to comment #16)
> (In reply to comment #15)
> > Patch checked in patch seems to be Rev1.0 (Attachment 309400 [details] [diff] [details]),
> > not Rev1.1 (Attachment 309425 [details] [diff] [details]).
>
> No problem.
> Not Rev1.0, but Rev1.1.
>
> See
> http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/extensions/reporter/locales/en-US/chrome/reporterOverlay.dtd&rev=1.5&cvsroot=/cvsroot
>
Ok, thank you.
But Bug 406083 may have problem of name of string .
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•