Jim Jeffery not reading bug-mail 1/2/11 Reporter
	Description • 16 years ago

Trying to play videos at www.msnbc.com opens the window but nothing loads or plays. 


MSNBC Works in 200803131647 build - broken in 200803131827 build 

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-03-13+15%3A00%3A00&maxdate=2008-03-13+19%3A00%3A00&cvsroot=%2Fcvsroot

Vista HP

	Matthias Versen [:Matti]
	Comment 1 • 16 years ago

could be bug 406251

	Johnny Stenback (:jst) Assignee
	Comment 2 • 16 years ago

Hmm, *really* shouldn't be bug 406251, I'd be surprised. I applied that patch to a tree from maybe two days ago, and the videos still play, so I'd look elsewhere.

	Matthias Versen [:Matti]
	Comment 3 • 16 years ago

FYI: Playing the videos is wfm with : 
Mozilla/5.0 (Windows; U; Windows NT 6.0; rv:1.9b5pre) Gecko/2008031400 SeaMonkey/2.0a1pre

	gabe
	Comment 4 • 16 years ago

having adblock plus installed and running makes this bug not appear (confuzed)

	Zulith
	Comment 5 • 16 years ago

Is this related to a similar problem that appeared recently on youtube? Videos on youtube.com don't load for me (but if they are embedded in another site, I can play them usually); I can't always reproduce. I've seen this problem both with and without adblock enabled (no, I don't have flashblock installed either).

	Jim Jeffery not reading bug-mail 1/2/11 Reporter
	Comment 6 • 16 years ago

When I filed I was using Flash 9.0r47, I just tried the 9.0r115 update, and its the same, the vids still won't play, so it appears that this issue is not flash version related. 

Could someone verify my regression range, maybe I missed something ?  I'm not a coder, so I can't begin to guess which patch caused this issue.  

Possible to back out all the patches in the range ?  I know its time consuming due to the long build to verify times now on the win32 box, but can we let B5 slip out the door with this problem ?

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008031701 Minefield/3.0b5pre Firefox/3.0 Firefox/2.0.0.12 ID:2008031701

	Jim Jeffery not reading bug-mail 1/2/11 Reporter
	Comment 7 • 16 years ago

When clicking on a vid link at www.msnbc.com a 'pop-up' window is spawned to play the vids.  This morning after the window came up, I right-clicked in the window and used:
1. View page info 
2. select the media tab
3. copy/paste the top listed url into a new tab in the browser
4. NOTE that the vids now play and work... 

no idea what this means... site issue ?  or something with the pop-up ?

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008031701 Minefield/3.0b5pre Firefox/3.0 Firefox/2.0.0.12 ID:2008031701

	Jim Jeffery not reading bug-mail 1/2/11 Reporter
	Comment 8 • 16 years ago

From another bug with Flash being broken with Flashblock installed, it appears that perhaps bug 401155 is the problem, could it be that bug 401155 is also the cause of this issue ?  Both Flashblock/Flash problems and this one started at the same time. 

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 9 • 16 years ago

Bug 401155 landed on the 14th, which is after the broken buildid in comment 0. It does work on a local build from right after my landing on windows XP.

Looks like a blocker though.

Is this Vista-only perhaps?

	JD
	Comment 10 • 16 years ago

I do believe i'm having this same issue or a similar issue on Linux. I can't pull a regression range though...For me, embedded videos (such as the video at: http://daily.mahalo.com ) don't show up when i have AdBlock Plus on, but they do show up as soon as i turn it off (and no, i didn't select to block them). Also, i have no other extensions installed that could possibly be causing this issue (All i have installed other than ABP and ABP Element Hiding Helper is Fission and Better Gmail)

	JD
	Comment 11 • 16 years ago

sorry...Also my flash version is 9.0 r115

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 12 • 16 years ago

That would sort of indicate that bug 401155 is the cause here...

	Johnny Stenback (:jst) Assignee
	Comment 13 • 16 years ago

This makes is so that we don't do delayed stopping of plugins when we don't need to (aDelayedStop is false in StopPluginInternal()). I don't understand why this is a problem, but plugins apparently don't like this. This should also fix bug 423260 (can't test right now as the site appears to not work at the moment), and also bug 423446.

	Johnny Stenback (:jst) Assignee
	Comment 14 • 16 years ago

Comment on attachment 310374 [details] [diff] [review]
Fix.

This needs a beta, and would've landed last night if it wasn't for the network outage that held the tree closed most of the evening :(

	Reed Loden [:reed]
	Comment 15 • 16 years ago

Comment on attachment 310374 [details] [diff] [review]
Fix.

This is a blocker. No approval required.

	Johnny Stenback (:jst) Assignee
	Comment 16 • 16 years ago

Fix checked in.

	Jim Jeffery not reading bug-mail 1/2/11 Reporter
	Comment 17 • 16 years ago

Confirmed, fixed in build: 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008031912 Minefield/3.0b5pre Firefox/3.0 Firefox/2.0.0.12 ID:2008031912  <-Latest hourly
Vista HP SP1

	JD
	Comment 18 • 16 years ago

I'll be able to test this myself tomorrow when the nightlies hit.

	Jeff Walden [:Waldo]
	Comment 19 • 16 years ago

Want an automated test eventually, but until then a manual test would be an improvement over nothing...

	Marcia Knous [:marcia]
	Comment 20 • 16 years ago

https://litmus.mozilla.org/show_test.cgi?id=5233 added which covers testing of several news sites, including msnbc.

	Giacomo Bordiga
	Comment 21 • 16 years ago

-#ifdef XP_WIN
-  // We only deal with delayed stopping of plugins on Win32 for now,
-  // as that's the only platform where we need to (AFAIK) and it's
-  // unclear how safe widget parenting is on other platforms.
-  if (aDelayedStop) {
-    // nsStopPluginRunnable will hold a strong reference to owner
-    // (mInstanceOwner), and thus keep it alive as long as it needs
-    // it.
-    nsCOMPtr<nsIRunnable> evt = new nsStopPluginRunnable(owner);
-    NS_DispatchToCurrentThread(evt);
-  } else
-#endif
-  {
-    DoStopPlugin(owner, PR_FALSE);
-  }
+  DoStopPlugin(owner, aDelayedStop);

Probably I'm just too unexperienced but to me it looks like on every platform the stopping of plugins is delayed and from the comment in the code "it's unclear how safe widget parenting is on other platforms" other than windows.