Closed
Bug 423085
Opened 17 years ago
Closed 17 years ago
[Bookmark] restore from JSON, Japanese is garbled
Categories
(Firefox :: Bookmarks & History, defect, P1)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3 beta5
People
(Reporter: bugmozz, Assigned: takenspc)
References
Details
(Keywords: regression)
Attachments
(2 files, 3 obsolete files)
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
(deleted),
image/jpeg
|
Details |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031415 Minefield/3.0b5pre ID:2008031415
original, http://img170.imageshack.us/img170/5185/a1if1.jpg
after restore, http://img228.imageshack.us/img228/5641/a2kz7.jpg
Assignee | ||
Comment 1•17 years ago
|
||
|unescape|-ing |encodeURIComponent|-ed string is wrong. We should use |decodeURIComponent|.
Updated•17 years ago
|
Severity: normal → major
Flags: blocking-firefox3?
Assignee | ||
Comment 2•17 years ago
|
||
Previous patch breaks backward compatibility for backup files today's build generated. This patch adds backward compatibility.
# |decodeURIComponent|-ing |encodeURIComponent|-ed string is doing nothing, make it simple :-).
Attachment #309594 -
Attachment is obsolete: true
Attachment #309608 -
Flags: review?(mano)
Attachment #309594 -
Flags: review?(mano)
Assignee | ||
Comment 3•17 years ago
|
||
Oops! Wrong file was uploaded!
Attachment #309608 -
Attachment is obsolete: true
Attachment #309610 -
Flags: review?(mano)
Attachment #309608 -
Flags: review?(mano)
Comment 4•17 years ago
|
||
Comment on attachment 309610 [details] [diff] [review]
Patch v2
I prefer breaking compat. rather than extending the file size that much, it's trunk!
Attachment #309610 -
Flags: review?(mano) → review-
Assignee | ||
Comment 5•17 years ago
|
||
OK. Simply pass the string.
Attachment #309610 -
Attachment is obsolete: true
Attachment #309627 -
Flags: review?(mano)
Updated•17 years ago
|
Attachment #309627 -
Flags: review?(mano) → review+
Updated•17 years ago
|
Attachment #309627 -
Flags: approval1.9?
Updated•17 years ago
|
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → Firefox 3 beta5
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Comment 6•17 years ago
|
||
mozilla/toolkit/components/places/src/utils.js 1.6
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Attachment #309627 -
Flags: approval1.9?
sorry, fixed.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031705 Minefield/3.0b5pre
1) delete old backup file
2) start/exit minefield
3) new backup file is created
(create new profile)
4) launch Minefield
5) open Library, Import and Backup >> Restore
6) choose above new backup file
maybe something wrong with old backup file.
Comment 9•17 years ago
|
||
verified with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre)
Gecko/2008032106 Minefield/3.0b5pre
and
Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9b5pre)
Gecko/2008032104 Minefield/3.0b5pre
Status: RESOLVED → VERIFIED
Comment 10•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•