Closed Bug 424050 Opened 17 years ago Closed 7 years ago

Results do not listen to annotation notifications, causing annotation depending queries to not liveupdate

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED INACTIVE

People

(Reporter: cmtalbert, Unassigned)

References

Details

Attachments

(2 files)

Attached file Testcase (deleted) —
If you are querying using query.annotation = x, then changing a query set member's annotation to a new name should remove that member from the query set. 1. Add item uri http://foo to the database with annotation Name x and annotation value y 2. Create a query using query.annotation = x 3. Change uri http://foo to use annotation name "text/somethingelse" instead of x. 4. Check the query result set. = Actual = Uri http://foo is still in the query set = Expected = Uri http://foo is no longer in the query set Attaching a XPCShell test for this.
Attached file header file for test (deleted) —
Blocks: 509868
So, the test is wrong, setting a new annotation won't remove the old one. But even fixing the test it is failing, so the issue could be real.
The fact a result is not an annotations service observer, could be a good candidate :\
So, if a query is using any annotation option, or is sorted by anno, it should be refreshed when the anno is removed or added, only in such a case the result should observe annotations changes, and report them to related nodes. we should use a similar way we do for folder observers, having an hash of annotations the result should listen to, with direct pointer to the relative query nodes and just calling refresh on the node.
Blocks: 511846
No longer blocks: 511846
Depends on: 511846
OS: Mac OS X → All
Hardware: PowerPC → All
Summary: Changing annotations does not delete item from query set via liveupdate → Results do not listen to annotation notifications, causing annotation depending queries to not liveupdate
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: