Closed
Bug 424375
Opened 17 years ago
Closed 17 years ago
high dpi - inconsistent widths and heights reported
Categories
(Core :: DOM: Core & HTML, defect, P2)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrmazda, Assigned: roc)
References
()
Details
(Whiteboard: [reviewed patch in hand])
Attachments
(4 files)
(deleted),
image/png
|
Details | |
(deleted),
text/html
|
Details | |
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
text/html
|
Details |
When DPI is 144 or more, CSS px units are used to report:
screen.width
screen.height
screen.availWidth
screen.availHeight
while screen px units are used to report:
window.outerWidth
window.outerHeight
window.innerWidth
window.innerHeight
The same units should be used for all. I recommend screen px units for the foreseeable future at least.
cf. bug 375519
Reporter | ||
Comment 1•17 years ago
|
||
FF 2.0.0.12 vs. FF 3.0b4 on OpenSUSE 10.2 in KDE @ 1920x1440
Comment 2•17 years ago
|
||
Pretty much anything exposed to content should probably be reporting CSS px, since any sizing content does will be in CSS px...
Assignee | ||
Comment 3•17 years ago
|
||
Yeah, I think we should fix outer* and inner*
Assignee | ||
Comment 4•17 years ago
|
||
Hmm, the code seems to indicate innerWidth and innerHeight are returned in CSS pixels. Not sure what's up with that. outerWidth and outerHeight should be easy to fix.
Assignee: nobody → roc
Flags: blocking1.9?
Reporter | ||
Comment 5•17 years ago
|
||
Roc, you're right. Again I was derelict in a comment 0. I'm guessing that I was going on ancient memory of 1.5a, maybe before the bug 375519 checkin, when both inners & outers matched in device px. Currently only the outers are in device px.
On Linux at least, desktop taskbar size is not being subtracted from screen.avail*. e.g. screen.height = screen.availHeight.
Reporter | ||
Updated•17 years ago
|
Attachment #312006 -
Attachment mime type: text/plain → text/html
Comment 6•17 years ago
|
||
Blocking as not fixing this now would make it significantly harder to fix later if people start depending on this broken behavior.
Flags: blocking1.9? → blocking1.9+
Priority: -- → P2
Reporter | ||
Comment 7•17 years ago
|
||
In up to date Kubuntu Hardy's FF 3.0b4 2008031317, all are displaying only device px. It looks and works just like branch. It too is not subtracting taskbar size from avail.
Flags: blocking1.9+ → blocking1.9?
Priority: P2 → --
Updated•17 years ago
|
Flags: blocking1.9? → blocking1.9+
Priority: -- → P2
Assignee | ||
Comment 8•17 years ago
|
||
Fixes getting and setting of outerWidth/outerHeight.
Attachment #312722 -
Flags: superreview?(jst)
Attachment #312722 -
Flags: review?(jst)
Assignee | ||
Comment 9•17 years ago
|
||
I'm not sure if this can be automated. We'd have to change layout.css.dpi on the fly which sounds scary.
Assignee | ||
Updated•17 years ago
|
Whiteboard: [needs review]
Updated•17 years ago
|
Attachment #312722 -
Flags: superreview?(jst)
Attachment #312722 -
Flags: superreview+
Attachment #312722 -
Flags: review?(jst)
Attachment #312722 -
Flags: review+
Assignee | ||
Updated•17 years ago
|
Whiteboard: [needs review] → [reviewed patch in hand]
Assignee | ||
Comment 10•17 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 11•17 years ago
|
||
Perhaps worth adding some sort of single-test harness or something, then, but we should still get this automated. Somehow. Eventually.
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•