Closed
Bug 424714
Opened 17 years ago
Closed 17 years ago
Redirect rules don't account for letters in version numbers
Categories
(support.mozilla.org :: General, defect, P1)
support.mozilla.org
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jason.barnabe, Assigned: reed)
References
Details
(Whiteboard: sumo_only urlhandling)
Attachments
(1 file)
(deleted),
patch
|
morgamic
:
review+
|
Details | Diff | Splinter Review |
Firefox version numbers can have letters in them, for example 3.0b5. I don't know if we need to document these things, but better safe than sorry.
Changing the regex to be "everything except /" would work.
Comment 1•17 years ago
|
||
Need this for bug 423486 to land for b5, so ASAP (tonight, if possible) would be great here. Was originally going to hack around this on the client side, but backing away from that.
Blocks: 423486
Priority: -- → P1
Assignee | ||
Comment 2•17 years ago
|
||
This is a very quick fix to get this working, but I think there's a lot of clean-up needed here. I'll file a follow-up on the other issues.
Attachment #311311 -
Flags: review?(morgamic)
Assignee | ||
Updated•17 years ago
|
Attachment #311311 -
Attachment description: Super dirty fix - v1 → Quick fix - v1
Updated•17 years ago
|
Attachment #311311 -
Flags: review?(morgamic) → review+
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → reed
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Whiteboard: sumo_only urlhandling
Updated•15 years ago
|
Flags: in-testsuite?
Comment 4•15 years ago
|
||
Some Firefox versions also have "rc" in them for e.g. 3.0rc2
This fix only accounts for alphabet 'a' and/or 'b'. It does not account for 'r' and 'c'.
Do we care for rc?
Assignee | ||
Comment 5•15 years ago
|
||
(In reply to comment #4)
> Some Firefox versions also have "rc" in them for e.g. 3.0rc2
> This fix only accounts for alphabet 'a' and/or 'b'. It does not account for 'r'
> and 'c'.
> Do we care for rc?
No Firefox releases in the last several years have actually had "rc" in their version number. That's just marketing nomenclature.
Comment 6•15 years ago
|
||
Verified, FIXED.
Status: RESOLVED → VERIFIED
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•