Closed Bug 424949 Opened 17 years ago Closed 15 years ago

Keyhole (back/forward buttons) in small iconic mode are too big

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set
minor

Tracking

()

RESOLVED DUPLICATE of bug 429062

People

(Reporter: whimboo, Unassigned)

References

Details

Attachments

(1 file)

Attached image Oversized keyhole image (deleted) —
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032405 Minefield/3.0b5pre ID:2008032405 With the patch on bug 423806 the back and forward buttons are also handled as a keyhole now. Therefor new images were created. But these images are oversized. They doesn't fit into the toolbar when having small iconic mode set. The keyhole size should be the same like the other toolbar buttons, e.g. Reload, or Stop. Ideally it will be the same height as before the patch was checked in.
Flags: blocking-firefox3?
At the most I think the keyhole should be the height of the address bar. It looks taller than the address bar right now. I think the keyhole is more equivalent to the address bar than a toolbar button because of the rounded sides which are like the left end of the address bar.
Depends on: 422559
Note that this is only a visual change, the size of the target area of the buttons, and the height of the navigation toolbar has not changed. The rationale is that the navigation buttons are more important than the other controls, so they deserve more visual weight, regardless of if the user is in large icon or small icon mode. Also, fitt's law is based on perceived target area, not actual target area, so this does make the buttons slightly easier to hit.
This doesn't block, but that doesn't mean that Alex and I aren't taking it under advisement (ie: the bug isn't invalid or wontfix at this point, either)
Flags: blocking-firefox3? → blocking-firefox3-
I think having white-on-colored is enough of visual emphasis. They already stand out much more than the other buttons because of that. I'd accept an argument for larger buttons if they were green arrows on a neutral background, but this just dominates. An aside perhaps but the throbber and the searchbar magnifying glass don't seem to have the same visual theme as the other buttons (one color, equal-weight lines, slightly rounded corners) so the whole thing looks a little inconsistent.
Severity: normal → minor
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: