User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032405 Minefield/3.0preb5 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032405 Minefield/3.0preb5 Now that the search button points to the right the lens looks too close to the right border. Adding a couple of pixels of margin may help it look more relaxed. Reproducible: Always Steps to Reproduce: 1. 2. 3.

This is a zoomed-in view illustrating the problem. In the address bar, there is a 3-pixel gap between the icons and the end, whereas in the search bar, that gap is only 1 pixel wide. Widening that gap to 3 pixels will improve consistency.

This patch will widen the gap to 3 pixels, making it consistent with the gap in the address bar.

Comment on attachment 315385 [details] [diff] [review] patch >Index: searchbar.css > .search-go-button { >- padding: 1px; >+ padding: 1px 3px; Should we only add padding on the right (-moz-padding-end), rather than on both sides? I don't want to reduce the width available for text too much, though 6 pixels probably isn't the end of the world.

(In reply to comment #4) > (From update of attachment 315385 [details] [diff] [review]) > >Index: searchbar.css > > > .search-go-button { > >- padding: 1px; > >+ padding: 1px 3px; > > Should we only add padding on the right (-moz-padding-end), rather than on both > sides? I don't want to reduce the width available for text too much, though 6 > pixels probably isn't the end of the world. > I did that at first, and that was the patch that I was going to post, but at the last minute, I changed me mind. * Fill the search box with text, and you'll see that the 1px gap seems rather small. * The gap between the text and the start of the icons at the end in the address bar in FF3 is also 3 px. * The gap between the engine selection button and the start of the text in FF3 is 4px. * The gap between the text and the search button in FF2 was also 3px. * And as you said, 6 pixels isn't that much. ;) If you want, I could change it to -moz-padding-end, but I think it'll look better this way (and it'll be consistent with the address bar's end spacing).

Comment on attachment 315385 [details] [diff] [review] patch By default the 16x16 pixel icon is located in a 22x22 pixel text field, so to make sure the padding is the same on the top, bottom and right, we should set it to 2px instead of 3px.

Here is what I think the ideal padding would be.

I had picked 3 pixels because that was the gap found in the address bar (see attachment 315383 [details]), so I figured that I'd use the same here for consistency. So if we change this to 2 pixels, should we change the icon padding in the address bar as well?

I think people notice padding differences based on what they are currently focused on. For instance, focus on the search magnifying glass and then try to see the padding in the location bar with your peripheral vision. The other issue is that outline on the drop marker is only visible on mouse hover. I know there was a bug on the padding of the location bar icons, but now I can't find it. Either way, they seem way to close to each other. Ideally the drop marker, star and Web feed icon would be separated from each other 4 pixels.

The 2-pixel version, per Alex's request. I tried it out, and I think that 3 pixels still looks a bit better. But maybe that's just because I've been using the 3-pixel version all night and had become used to it. Note: I used 2px all around instead of 1px/vert 2px/horz to prevent the top and bottom gaps from collapsing down to 1px if for some odd reason the search box height shrinks.

Comment on attachment 315472 [details] [diff] [review] patch v2 Thanks, the new search button will also be visually a little smaller, so that will add to the amount of white space around it.

Comment on attachment 315472 [details] [diff] [review] patch v2 a1.9=beltzner

not a blocker, but someone should land this patch...

mozilla/browser/themes/winstripe/browser/searchbar.css 1.26