User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield nightly Firefox/3.0b5pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield nightly Firefox/3.0b5pre Spinoff from bug 407008. Currently, the empty user level extension extension folder (at C:\Users\[USERNAME]\AppData\Roaming\Mozilla\Extensions\{ec8030f7-c20a-464f-9b0e-13a3a9e97384} on Vista) is left behind on uninstall; this should be removed. Reproducible: Always

Remove %APPDATA%\Mozilla\{ec8030f7-c20a-464f-9b0e-13a3a9e97384} recursively and remove %APPDATA%\Mozilla if it is empty when removing personal data

I don't understand. Comment0 has appdata/roaming/Mozilla/Extensions/{ec...} the patch has appdata/Mozilla/{ec...} Who created this directory? What does it have in it?

It had the wrong path It was added as part of bug 311008

Comment on attachment 315171 [details] [diff] [review] patch rev2 If an external app installs an extension to this directory, I don't think we should be removing it... or am I missing something?

I considered going with just removing it when empty and can change it accordingly. The concern I have is that if the user experiences problems with the extension and expects cleaning personal data to fix it.

Comment on attachment 315175 [details] [diff] [review] patch rev3 - only remove when empty Drivers, this is a simple / safe fix that removes empty directories when personal data is removed during install. IIRC the removal of empty directories is one of the requirements on the PRD so I am asking for a1.9.

Comment on attachment 315175 [details] [diff] [review] patch rev3 - only remove when empty a1.9=beltzner

Checked in to trunk Checking in mozilla/browser/installer/windows/nsis/uninstaller.nsi; /cvsroot/mozilla/browser/installer/windows/nsis/uninstaller.nsi,v <-- uninstaller.nsi new revision: 1.20; previous revision: 1.19 done

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008041506 Minefield/3.0pre. I verified by testing both uninstalling and checking the box to remove the user directory as well as not checking the box with extensions installed.