Closed
Bug 425125
Opened 17 years ago
Closed 17 years ago
Incorrect variable usage leads to wrong READONLY state for ARIA widgets
Categories
(Core :: Disability Access APIs, defect, P1)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: aaronlev, Assigned: aaronlev)
References
(Blocks 1 open bug)
Details
(Keywords: access, regression)
Attachments
(1 file)
|
(deleted),
patch
|
surkov
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
In nsAccessible::GetARIAState() we are using a variable called ariaState which never affects the output of the method. This bug was introduced in bug 419416.
|
Assignee | |
Comment 1•17 years ago
|
||
The built-in, automatically applied states that some ARIA roles have are also broken from the same issue.
|
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #311724 -
Flags: review?(surkov.alexander)
|
||
Comment 3•17 years ago
|
||
Comment on attachment 311724 [details] [diff] [review]
Fix variable usage
r=me
Attachment #311724 -
Flags: review?(surkov.alexander)
Attachment #311724 -
Flags: review+
Attachment #311724 -
Flags: approval1.9?
|
||
Comment 4•17 years ago
|
||
The absence of this patch breaks ARIA controls in a wide range. Requesting blocking and setting priority
Severity: normal → major
Flags: blocking1.9?
Priority: -- → P1
Target Milestone: --- → mozilla1.9
Version: unspecified → Trunk
|
||
Comment 5•17 years ago
|
||
Comment on attachment 311724 [details] [diff] [review]
Fix variable usage
a=beltzner
Attachment #311724 -
Flags: approval1.9? → approval1.9+
|
|
||
Comment 6•17 years ago
|
||
Requesting that this be checked in on Aaron's behalf. He's on the move to Germany and away from the computer for a couple of days. Thanks!
Keywords: checkin-needed
|
||
Comment 7•17 years ago
|
||
Checking in mozilla/accessible/src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v <-- nsAccessible.cpp
new revision: 1.367; previous revision: 1.366
done
|
|
||
Updated•7 years ago
|
Flags: blocking1.9?
You need to log in
before you can comment on or make changes to this bug.
Description
•